Fix compatibility with PHP 7.4 #199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function ReflectionType::__toString() is deprecated, use getName() instead.
mabar
reviewed
Sep 24, 2019
| ? new \ReflectionMethod($callback[0], $callback[1]) | ||
| : new \ReflectionFunction($callback); | ||
| $this->_static[$name][1] = ($tmp = $ref->getParameters()) | ||
| && $tmp[0]->getType() !== null |
There was a problem hiding this comment.
Btw, did you find why is it null at PHP 7.4?
Contributor
Author
There was a problem hiding this comment.
I think that all tests failed, before getName function, it was casted to string, so it could not be null in if check
Member
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Sep 24, 2019
Contributor
Author
|
Thanks for merging so quick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function ReflectionType::__toString() is deprecated, use getName() instead.