RequestFactory: fix X-Forwarded-Host mixup with remote host #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d11e41 to
1ff390b
Compare
1ff390b to
65d8278
Compare
Member
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Mar 18, 2023
dg
pushed a commit
that referenced
this pull request
Mar 18, 2023
dg
pushed a commit
that referenced
this pull request
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading #221, I noticed
X-Forwarded-Hostis incorrectly used for remote host.X-Forwarded-Host is in no way related to remote host.
X-Forwarded-Host contain value of
Hostheader that client sent to the proxy.Remote host is related to remote addr (client ip).