Skip to content

Conversation

@matyx
Copy link
Contributor

@matyx matyx commented Oct 3, 2016

Copy link
Contributor

@fprochazka fprochazka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dg
Copy link
Member

dg commented Oct 5, 2016

Do you think this is useful?

@matyx
Copy link
Contributor Author

matyx commented Oct 5, 2016

@fprochazka Yes, I will add them.
@dg I need only 429 - Too many requests (for API). I added all from the RFC only because of completness

@fprochazka
Copy link
Contributor

@dg it's better to have those codes as constants. And it's weird to have half defined in nette and half in custom class.

@Majkl578
Copy link
Contributor

Majkl578 commented Oct 5, 2016

There is even more codes missing here, see Symfony's Response constants: https://github.com/symfony/symfony/blob/c0a26bc/src/Symfony/Component/HttpFoundation/Response.php#L21-L82

@matyx
Copy link
Contributor Author

matyx commented Oct 5, 2016

I've added all missing response codes

@stepansvoboda
Copy link
Contributor

🎩

@stepansvoboda
Copy link
Contributor

As for community-driven development this a good pull request!

👍

@fprochazka
Copy link
Contributor

@matyx awesome 👍

@dg dg merged commit d137702 into nette:master Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants