Form: addRule (regex) is not validating after addFilter

[solcik]

• bug fix
• BC break? no
• doc PR:

Hello David @dg,

https://github.com/nette/docs/blob/doc-3.1/cs/form-validation.texy#L179-L192

When I tried addFilter as mentioned in docs, it does transform the value, but the validator after that does not validate.
Here is a failing test for that use-case.

I think that problem is here somewhere about here.

https://github.com/nette/forms/blob/master/src/Forms/Controls/TextInput.php#L72-L73

I am not sure, how to fix that, so I do not break anything else.

Thank you very much in advance.

[dg]

Thanks for tests!

[Daaarkling]

Hi @dg. I'm still having some trouble with this. Rules are not generated into html. I'm on current version 3.1.2

$form = new Form();

// nope
$form->addText('test')
	->addFilter(fn ($value) => $value)
	->addRule(Form::FLOAT);

// ok
$form->addText('test2')
	->addRule(Form::FLOAT)
	->addFilter(fn ($value) => $value);

return $form;

{control form}

<input type="text" name="test" id="frm-testForm-test" class="text">
<input type="text" name="test2" id="frm-testForm-test2" data-nette-rules="[{&quot;op&quot;:&quot;:float&quot;,&quot;msg&quot;:&quot;Please enter a valid number.&quot;}]" class="text">

Could you pls double check that fix. Thank you 🤗

[janpecha]

@Daaarkling IMHO it's correct behavior, see #259