Use phpstan callable definitions

[adaamz]

• new feature
• BC break? no

Hi,
are you interested in definition for callables like phpstan does?
format is like in php (without parameter names) callable(params): return_type

If you are interested I can change other classes/packages.

[dg]

Is it supported by IDEs?

[adaamz]

PhpStorm "supports" intersection workaround in format
callable[]&(callable(Form): void)[]

I do not have other IDEs like Eclipse or NetBeans...

[dg]

It seems good.

[adaamz]

Fixed union on Form::onSuccess.
Used phpstan syntax in other classes - SubmitButton and Container.

[ondrejmirtes]

👍 from me

[dg]

Thanks! Can you post PR for Application too?

[ondrejmirtes]

This isn't exactly typesafe, we'd like to use:

// $form is our own CustomForm extending Nette\Forms\Form
$form->onSuccess[] = function (CustomForm $form): void {
});

Since in onSuccess there's callable(\Nette\Forms\Form), it's not typesafe to ask for a subtype in the callable. Nette might pass a different instance in there. I'm gonna experiment with callable(static) instead.

No need to change anything in Nette - phpstan-nette extension for PHPStan 0.12. will contain the fixed stub :) (Yeah, I've added support for custom phpDoc stubs to fix 3rd party phpDocs.)

[dg]

This callable(Form) exists for PHPStan only, so there is no problem to change it to callable(static)

[ondrejmirtes]

Let me first check if it works.

On Tue, 26 Nov 2019 at 15:40, David Grudl ***@***.***> wrote: This callable(Form) exists for PHPStan only, so there is no problem to change it to callable(static) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#216?email_source=notifications&email_token=AAAZTODDHQSOXGK65JJOYADQVUYPVA5CNFSM4G6V4CBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFGHQ6A#issuecomment-558659704>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAZTOBJ4ZYXNATZTXNYLXDQVUYPVANCNFSM4G6V4CBA> .

-- Ondřej Mirtes