UploadControl: Added setAllowedType #172
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@JanTvrdik ou, ok I will remove js, and rebase. Firefox 👎 |
And add attribute accept with mime types Removed empty line Fix: condition to check type Fix: conding-standard
Author
|
@JanTvrdik https://bugzilla.mozilla.org/show_bug.cgi?id=373621, fixed ? I tried js log and firefox (57.0) return same type as chrome |
Contributor
|
@JanGalek The commit is from 2014 and the issue is resolved. But it's still sth that need's to be considered. |
Author
|
@JanTvrdik ok, and if we Dtect firefox <= 50 and type needed is application/pdf than we allow application/x-download with check extension ? Problem was with PDF right ? |
Member
|
What about to add attribute |
43a2ab1 to
c2d4d93
Compare
f3a77d7 to
880142b
Compare
dg
added a commit
that referenced
this pull request
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new method to UploadControl, whitch set mimeTypes and attribute accept.