Idea: ContainerBuilder: avoid fopen if file is in opcode cache #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Not sure if I am correct but I traced file reading back to zend_fopen_wrapper, is that the function that ultimately loads the script?
|
For stated purpose (no disk touching) it would be necessary to use shared memory for locking ie.: shm_get_var or semaphore. It would be possible to this this on systems that have OPcache and Semaphore enabled (linux only). |
dg
added a commit
that referenced
this pull request
Nov 16, 2014
dg
added a commit
that referenced
this pull request
Nov 16, 2014
dg
added a commit
that referenced
this pull request
Nov 16, 2014
dg
added a commit
that referenced
this pull request
Dec 14, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bored at school I got an idea to avoid touching disk for PHP 5.5.11+. It relies on undocumented function opcache_is_script_cached (http://stackoverflow.com/questions/23229849/opcache-is-script-cached-function-in-php5-5-11).
Not sure how to solve the atomicity. We may use
@includeand check return value forFALSE.