Skip to content

[ContainerBuilder] getDefinitionByType() method added #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dg merged 1 commit into from
Jan 7, 2017
Merged

[ContainerBuilder] getDefinitionByType() method added #137

dg merged 1 commit into from
Jan 7, 2017

Conversation

@TomasVotruba
Copy link
Contributor

@TomasVotruba TomasVotruba commented Jan 4, 2017

All is described in the issue: #130

Behavior is compatible with with getDefiniton() - exception is thrown when not found.
This method is called in cases where Definition is required.

@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Jan 7, 2017

Ping @dg

@dg
Copy link
Member

dg commented Jan 7, 2017

Ping @TomasVotruba :-) https://github.com/nette/di/pull/137/files/09079155c3d878ebf5f7e42b9d4a58889978aede#diff-a46f14857c4aea27829419b9d1474390

@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Jan 7, 2017 •
edited
Loading

What needs to be done here?

@dg
Copy link
Member

dg commented Jan 7, 2017

Can it return NULL?

@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Jan 7, 2017 •
edited
Loading

Well, that was my first idea. But having getDefiniton() throwing exception and getDefinitonByType() giving NULL seems inconsistent.

What do you think?

@dg
Copy link
Member

dg commented Jan 7, 2017

So annotation @return should be fixed.

@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Jan 7, 2017

I see. That is leftover from 1st idea.

Fixed!

@dg
Copy link
Member

dg commented Jan 7, 2017

Great, thanks!

@dg dg merged commit 5ea207b into nette:master Jan 7, 2017
@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Jan 7, 2017

Awesome, thanks a lot!

@TomasVotruba TomasVotruba deleted the get-definition-by-type branch January 7, 2017 17:51
dg pushed a commit that referenced this pull request Jan 9, 2017
@dg
ContainerBuilder: getDefinitionByType() method added [closes #130] (#137
70b57e9 
)
@TomasVotruba TomasVotruba mentioned this pull request Jan 11, 2017
Closed
@TomasVotruba
Copy link
Contributor Author

TomasVotruba commented Jan 28, 2017

For others, here are all use cases I used it in:

deprecated-packages/symplify@1e8854c

Requires nette\di 2.4.6+

dg
dg reviewed May 2, 2017
View reviewed changes
src/DI/ContainerBuilder.php Outdated
/**
* Gets the service definition of the specified type.
* @param string
* @return ServiceDefinition|NULL
Copy link
Member

@dg dg Jan 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it return NULL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dg dg dg left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TomasVotruba @dg