Skip to content

Implement SQL Clause in Where IS NOT NULL #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dg merged 18 commits into from
Apr 23, 2019
Merged

Implement SQL Clause in Where IS NOT NULL #226

dg merged 18 commits into from
Apr 23, 2019
+16 −2

Conversation

@nargotik
Copy link
Contributor

@nargotik nargotik commented Apr 12, 2019

  • new feature
  • BC break no
  • doc PR: nette/docs

Daniel added 2 commits April 12, 2019 17:08
Implement Where Cause IS NOT NULL
c1c2a17 
Allow usage of IS NOT NULL
Passing arguments on array like
 'database_field NOT' => NULL,

Will represent SQL query
`database_field` IS NOT NULL
Implement Where Cause IS NOT NULL
929104c 
Allow usage of IS NOT NULL
Passing arguments on array like
 'database_field NOT' => NULL,

Will represent SQL query
`database_field` IS NOT NULL
@dg
Copy link
Member

dg commented Apr 12, 2019

Please do not reopen new pull request, you can change code via force push.

Implement Where Cause IS NOT NULL
f646690 
Allow usage of IS NOT NULL
Passing arguments on array like
 'database_field NOT' => NULL,

Will represent SQL query
`database_field` IS NOT NULL
@nargotik
Copy link
Contributor Author

nargotik commented Apr 12, 2019

Sorry about it, i'm kinda noob in Git :)

Daniel added 2 commits April 12, 2019 17:32
Implement Where Cause IS NOT NULL
186e403 
Allow usage of IS NOT NULL
Passing arguments on array like
 'database_field NOT' => NULL,

Will represent SQL query
`database_field` IS NOT NULL
Implement Where Cause IS NOT NULL
4c7d646 
Allow usage of IS NOT NULL
Passing arguments on array like
 'database_field NOT' => NULL,

Will represent SQL query
`database_field` IS NOT NULL
@nargotik
Copy link
Contributor Author

nargotik commented Apr 22, 2019

Please do not reopen new pull request, you can change code via force push.

Have you view this implementation ?

@matej21
Copy link
Contributor

matej21 commented Apr 23, 2019

@nargotik test is still missing.
I think it should be enough if you modify this test:

database/tests/Database/SqlPreprocessor.phpt

Line 101 in 8b6230d

test(function () use ($preprocessor) { // where

@nargotik
Copy link
Contributor Author

nargotik commented Apr 23, 2019

@nargotik test is still missing.
I think it should be enough if you modify this test:

database/tests/Database/SqlPreprocessor.phpt

Line 101 in 8b6230d

test(function () use ($preprocessor) { // where

Ok added, test

Failing test from coveralls mentions a file not changed at all :-)
Failing test appveyor is because of dns problem in getcomposer

@dg
Copy link
Member

dg commented Apr 23, 2019

Thanks!

@dg dg merged commit ff54cdc into nette:master Apr 23, 2019
dg pushed a commit that referenced this pull request Apr 23, 2019
@nargotik @dg
SqlPreprocessor: generates IS NOT NULL (#226)
9eeebcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nargotik @dg @matej21