Add @return never to redirect methods
#304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks |
This was referenced Jan 12, 2023
Contributor
Author
|
Hi @dg, do you have a plan when this will be released? Thanks! |
Member
|
It is in v3.1.4 |
Contributor
Author
|
3.1.4 was released before this PR was authored, maybe you mean #291 but that's a different PR. This one wasn't released yet. |
Member
|
You're right, I guess I lost this commit. I'll release it in the next patch version. |
dg
pushed a commit
that referenced
this pull request
Jan 17, 2023
Contributor
Author
|
Happens :-) Thank you! |
dg
pushed a commit
that referenced
this pull request
Jan 17, 2023
dg
pushed a commit
that referenced
this pull request
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
@return nevertoComponent::redirect()andComponent::redirectPermanent(), useful for static analysis and required when any method using either of those wants to useneveras its return type declaration (function foo(): never).Presenter::redirectUrl()already uses it, this PR "propagates" it further.Thank you!