Skip to content

BadRequestException parent Exception expect Throwable #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dg merged 1 commit into from
Oct 21, 2019
Merged

BadRequestException parent Exception expect Throwable #236

dg merged 1 commit into from
Oct 21, 2019

Conversation

@milous
Copy link
Contributor

@milous milous commented Oct 21, 2019

  • bug fix
  • BC break? no

https://www.php.net/manual/en/class.exception.php

public __construct ([ string $message = "" [, int $code = 0 [, Throwable $previous = NULL ]]] )

The third parameter can be only \Throwable

@dg
Copy link
Member

dg commented Oct 21, 2019

Thanks

@dg dg merged commit 69a0402 into nette:master Oct 21, 2019
@milous milous deleted the milous-patch-1 branch October 21, 2019 11:12
dg pushed a commit that referenced this pull request Oct 21, 2019
@milous @dg
BadRequestException: parent exception is Throwable (#236)
b912f96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@milous @dg