-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #17653 Add function to trim whitespaces in export templates via jinja environment settings #19078
Merged
jeremystretch
merged 16 commits into
netbox-community:feature
from
renatoalmeidaoliveira:17653-add-extra-fields-and-render-params-to-ConfigTemplate
Apr 8, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Apr 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you're completing the checklist for extending models each time you add a new field. The REST API serializers, GraphQL types, and several forms also need to be updated to reflect the new fields.
netbox/extras/migrations/0127_configtemplate_as_attachment_and_more.py
Outdated
Show resolved
Hide resolved
jeremystretch
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17653 Add function to trim whitespaces in export templates via jinja environment settings
RenderMixin
model with fields:template_code
,environment_params
,mime_type
,file_name
,file_extension
,as_attachment
RenderMixin
toExportTemplate
andConfigTemplate
, removing the repeated fieldsRenderMixin
usingExportTemplate
as reference for exports, i.e. always usingtemplate_code
instead of usingdata_file
when exists, becausetemplate_code
should be equals todata_file
aftersync
and it gives the end user more control of what template is in use.Extra Comments:
file_name
andfile_extension
toConfigTemplate
may give the user more flexibility in ZTP use cases using NetBox as source of python ZTP configuration files,