Draft
Conversation
8e5338e to
56ce443
Compare
56ce443 to
d49de29
Compare
Collaborator
|
Not convinced we need this one... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have the same situation that is described in this PR
ory/x#806
A customer is using range 198.18.0.0/16 for their K8s services, and kratos is therefore unable to access other services (perminator in our case).
The situation comes from SSRF component used by kratos, that limits access to these IP ranges:
https://github.com/daenney/ssrf/blob/main/ssrf_gen.go#L49