Conversation
There was a problem hiding this comment.
Found 18 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 21 potential problems in the proposed changes. Check the Files changed tab for more details.
18ee966 to
1030705
Compare
There was a problem hiding this comment.
Found 21 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 21 potential problems in the proposed changes. Check the Files changed tab for more details.
dmknutsen
approved these changes
Aug 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
strcpyuse and inDS_FileCreateDestw/ bad size tostrncpy#46Also removes the custom defined DS_STRING_TERMINATOR since anything other than '\0' would break standard calls.
Testing performed
CI
Expected behavior changes
No longer possible to overflow the various string buffers.
System(s) tested on
CI
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC