Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel Support #27

Closed
wants to merge 1 commit into from
Closed

Add Laravel Support #27

wants to merge 1 commit into from

Conversation

Rihoj
Copy link

@Rihoj Rihoj commented May 19, 2018

It took me 4+ hours to get this up and running, and to get laravel to work on my system, granted I was not framiliar with nginx and I had other issues with a deprecated package in source code. However, I found that maybe adding some parameters from the ENV file would help allow more customization and easier deployments for people who are new to this.

@Rihoj
Copy link
Author

Rihoj commented May 20, 2018

I am not sure how I am supposed to fix the Travis CI build.

getShortName from ReflectionFunctionAbstract.php is failing on line 152. It expects to return a string and it is returning an object.

return $this->node->name;

That is returning:

PhpParser\Node\Identifier Object
(
    [name] => getName
    [attributes:protected] => Array
        (
            [startLine] => 7
            [endLine] => 7
        )

)

and the $this->node is as follows:

PhpParser\Node\Stmt\ClassMethod Object
(
    [flags] => 1
    [byRef] => 
    [name] => PhpParser\Node\Identifier Object
        (
            [name] => getName
            [attributes:protected] => Array
                (
                    [startLine] => 7
                    [endLine] => 7
                )

        )

    [params] => Array
        (
        )

    [returnType] => 
    [stmts] => Array
        (
            [0] => PhpParser\Node\Stmt\Return_ Object
                (
                    [expr] => PhpParser\Node\Scalar\String_ Object
                        (
                            [value] => Nginx PHP MySQL
                            [attributes:protected] => Array
                                (
                                    [startLine] => 9
                                    [endLine] => 9
                                    [kind] => 1
                                )

                        )

                    [attributes:protected] => Array
                        (
                            [startLine] => 9
                            [endLine] => 9
                        )

                )

        )

    [attributes:protected] => Array
        (
            [startLine] => 7
            [endLine] => 10
        )

)

This seems like it has nothing to do with what my changes are, however if there is something I can do to fix this please let me know.

@nanoninja
Copy link
Owner

Hi @Rihoj,

Thanks for your contribution, I'll check your pull request.

@nanoninja nanoninja changed the base branch from master to dev May 21, 2018 08:12
@Rihoj Rihoj mentioned this pull request Nov 8, 2018
@Rihoj
Copy link
Author

Rihoj commented Nov 12, 2018

@nanoninja, are you still looking into this?

@nanoninja
Copy link
Owner

@Rihoj sorry for my late response. I haven't had a lot of time to work on this project.

The problem with the support of Laravel is not Laravel but that it would be necessary to make a system of templates to adapt it to the different frameworks.

It would be interesting to make a version 2 and make the configuration simple and flexible. A bit like a MAMP but Docker style. We can already improve it as it is, but at the moment I don't have too much time. It would take contributors like you to add value.

I will try to take the time to improve this application.
For the pull request that you made the tests did not pass, you have to look at why.

@Rihoj
Copy link
Author

Rihoj commented Jun 27, 2022

Closing due to inactivity.

@Rihoj Rihoj closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants