Skip to content

Conversation

@emilsas
Copy link
Collaborator

@emilsas emilsas commented Jan 19, 2026

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Walkthrough

The pull request reorganizes FFmpeg dependency handling in CMakeLists.txt by inverting the plugin-build condition logic. FFmpeg and Moq wiring now triggers when BUILD_PLUGIN is enabled instead of when disabled. The configuration adds FFmpeg discovery via pkg-config and wires include directories, library directories, and libraries within the BUILD_PLUGIN branch, while maintaining fallback to FindPackage(FFmpeg) in the alternative path. A previously isolated FFmpeg dependency block is removed and consolidated into the updated conditional structure. Existing OBS library linkage and MOQ setup are preserved within the reorganized flow.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author. Add a description explaining the FFmpeg discovery changes, the reason for conditional handling based on BUILD_PLUGIN, and any testing performed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: modifying FFmpeg discovery logic in the BUILD_PLUGIN conditional path for OBS fork builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@emilsas emilsas merged commit 32a156c into moq-dev:main Jan 19, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant