Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Tipseen): remove deprecated props [breaking] #2229

Open
wants to merge 2 commits into
base: vibe3
Choose a base branch
from

Conversation

talkor
Copy link
Contributor

@talkor talkor commented Jul 14, 2024

@talkor talkor added breaking change vibe3 Related to 3.0 major labels Jul 14, 2024
@talkor talkor requested a review from a team as a code owner July 14, 2024 12:00
@talkor talkor changed the title chore(Tipseen): remove deprecated props chore(Tipseen): remove deprecated props [breaking] Jul 14, 2024
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add in the changelog what the codemod should do in this case?

@talkor
Copy link
Contributor Author

talkor commented Jul 14, 2024

Can you please add in the changelog what the codemod should do in this case?

I don't think we should add a codemod here since some customization is no longer supported and requires developer's attention

@YossiSaadi
Copy link
Contributor

Can you please add in the changelog what the codemod should do in this case?

I don't think we should add a codemod here since some customization is no longer supported and requires developer's attention

I think we should consider injecting a TODO comment on everywhere we're not planning to touch with the codemod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change vibe3 Related to 3.0 major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants