-
Notifications
You must be signed in to change notification settings - Fork 452
Update readme #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme #849
Conversation
Summary of ChangesHello @vinci-grape, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the project's documentation, particularly the main Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces significant updates, primarily adding a new WebUI feature and renaming the 'Code Scratch' project to 'Code Genesis'. The README.md has been extensively updated to reflect these changes, including new sections for 'Agent Skills' and 'WebUI'. The changes also integrate the WebUI's dependencies and startup command into the main package.
My review focuses on the documentation and configuration changes. I've pointed out a small HTML issue in the README.md and a redundant instruction in the agent's system prompt in agent.yaml. Overall, the changes look good and significantly enhance the project's usability and feature set.
| ``` | ||
|
|
||
| <div align="center"> | ||
| <img src="https://github.com/user-attachments/assets/841fd06e-3611-4b27-86e0-4881963639bd" img width="2940" height="1670" alt="LocalGradioApplication" width="750"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The <img> tag has invalid HTML. It contains an extraneous img attribute and a duplicated width attribute. This should be corrected for valid HTML and predictable rendering.
| <img src="https://github.com/user-attachments/assets/841fd06e-3611-4b27-86e0-4881963639bd" img width="2940" height="1670" alt="LocalGradioApplication" width="750"> | |
| <img src="https://github.com/user-attachments/assets/841fd06e-3611-4b27-86e0-4881963639bd" alt="LocalGradioApplication" width="750"> |
| **Important: Always respond in the same language the user is using.** | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This instruction is redundant as it's already covered by instruction #7 on line 33: Respond in the same language the user uses. If the user switches, switch accordingly.. Removing this repeated instruction and the following blank line will make the prompt more concise and avoid potential confusion for the language model, while also slightly reducing token usage.
Change Summary
Update the workflow and simple_workflow diagrams in the PR_ARTICLE
Related issue number
Checklist
pre-commit installandpre-commit run --all-filesbefore git commit, and passed lint check.