Add a minimal CI #13
Merged
Add a minimal CI #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@ericsnowcurrently said using the white list is fine for this. @matajoh my only concern is that some of the tests were failing with a different exception, so we might have unintentionally altered behaviour. I would propose we get the CI up and running ASAP, and leave an issue to double check the behaviour for those tests. |
mjp41
added a commit
that referenced
this pull request
Dec 6, 2024
* Add a minimal CI * Apply static to internal functions. * Regened files and added a missing entry. * Change error to fix tests. * Manually allowing exception.
mjp41
added a commit
that referenced
this pull request
Dec 6, 2024
* Add a minimal CI * Apply static to internal functions. * Regened files and added a missing entry. * Change error to fix tests. * Manually allowing exception.
mjp41
added a commit
that referenced
this pull request
Dec 6, 2024
* Add a minimal CI * Apply static to internal functions. * Regened files and added a missing entry. * Change error to fix tests. * Manually allowing exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.