Skip to content

Honor more cursor settings in scm input editor#242903

Merged
lszomoru merged 1 commit intomicrosoft:mainfrom
jacekkopecky:git-commit-message-cursor-fix
Mar 18, 2025
Merged

Honor more cursor settings in scm input editor#242903
lszomoru merged 1 commit intomicrosoft:mainfrom
jacekkopecky:git-commit-message-cursor-fix

Conversation

@jacekkopecky
Copy link
Contributor

Previously it used cursorBlinking, now it also uses cursorWidth (default to 1 as before) and cursorStyle.

This addresses #242901

I might prefer the platform-default cursor in the git commit message editor because it looks more like <input> than like code editor, but this is the simplest fix for my issue.

Previously it used cursorBlinking, now it also uses
cursorWidth (default to 1 as before) and cursorStyle.
@jacekkopecky
Copy link
Contributor Author

@lszomoru Hi, is there anything I can do to get community PR approvals?

@lszomoru lszomoru added the scm General SCM compound issues label Mar 18, 2025
@lszomoru lszomoru added this to the March 2025 milestone Mar 18, 2025
@lszomoru lszomoru enabled auto-merge (squash) March 18, 2025 10:26
@lszomoru
Copy link
Member

@jacekkopecky. thank you very much for your contribution.

@lszomoru lszomoru merged commit dd750fb into microsoft:main Mar 18, 2025
7 checks passed
@jacekkopecky
Copy link
Contributor Author

Thank you @lszomoru !
Process question: any chance you know how to bump #214611 ? It's similarly small...

Copy link

@Abdullah4345 Abdullah4345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scm General SCM compound issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants