Make telemetry info table a little bit narrower and aligned

[mattmaniak]

The current table in defaultSettings.json was formatted using variables from the telemetryService.ts which are longer than the variables' content itself.

Fixes: #233959

Before:

	// |       | Crash Reports | Error Telemetry | Usage Data |
	// |:------|:---------------------:|:---------------:|:--------------:|
	// | all   |            ✓          |        ✓        |        ✓       |
	// | error |            ✓          |        ✓        |        -       |
	// | crash |            ✓          |        -        |        -       |
	// | off   |            -          |        -        |        -       |

After:

	// |       | Crash Reports | Error Telemetry | Usage Data |
	// |:------|:-------------:|:---------------:|:----------:|
	// | all   |       ✓       |        ✓        |     ✓      |
	// | error |       ✓       |        ✓        |     -      |
	// | crash |       ✓       |        -        |     -      |
	// | off   |       -       |        -        |     -      |

[lramos15]

Can you attach a photo of what the table now looks like in the settings UI? As it appears aligned already there and that was the case we were optimizing for as that is where most people edit their settings.

[mattmaniak]

Here it is how it looks by default:

...and how it looks like this after my fix:

The alignment is present but only for the defaultSettings.json generator. Look that the variables that hold column titles are longer that the titles itself, eg. ${crashReportsHeader} is longer than the Crash Reports title:

[lramos15]

I mean in the settings UI. I just want to ensure your fix doesn't regress this UI. I don't believe it will as markdown tables don't care about spacing, but it is good to validate

[mattmaniak]

In Settings UI it looks perfectly as above. It was kinda misleading because I keep to manage my configuration from .json mostly rather than UI. But if it would be possible to keep Settings UI aligned and defaultSettings.json also it would be great. However I suppose that defaultSettings.json is somehow used for rendering UI. Am I right?

[lramos15]

However I suppose that defaultSettings.json is somehow used for rendering UI. Am I right?

That's right, they're the same

[mattmaniak]

Perfectly as above - without my changes currently. I will switch enviro and write down the status cause I made a quick check on my second station. I thought that you mean if there is a UI bug by default on my instance. Sorry for the potential confusion.

[mattmaniak]

I can confirm that the change does not regress the Settings UI table so we can proceed.

[lramos15]

@mattmaniak Is there anyways we can make the | aligned as well? I see in the default.json they're now

[mattmaniak]

I will report such when found in a separate Issue/PR because I am not sure where to locate every generated table in the editor.

[lramos15]

I just meant for the telemetry table, not all of them. If we're fixing the alignment in this PR. We might as well fix the alignment completely and ensure the column separators are properly aligned.

[mattmaniak]

Understood. I don't see a solution for aligning the "text" column fully in json as the checkmark sign (✓) seems to be a little wider than the rest of monospace characters. Column separators have the same number of spaces before and after dash and checkmark signs. As an exception, GitHub Mobile treats the checkmark as a fully monospaced character...