Skip to content

fix: tweak check-requirements for calling ldconfig#202645

Merged
deepak1556 merged 4 commits intomicrosoft:mainfrom
Leask:main
Jan 18, 2024
Merged

fix: tweak check-requirements for calling ldconfig#202645
deepak1556 merged 4 commits intomicrosoft:mainfrom
Leask:main

Conversation

@Leask
Copy link
Contributor

@Leask Leask commented Jan 17, 2024

Sometimes, the target system has ldconfig ready, but you can not assume that /sbin is in $PATH. This may cause the installation of 'ssh remote' to fail.

Fixes microsoft/vscode-remote-release#9405

@Leask
Copy link
Contributor Author

Leask commented Jan 17, 2024

Screenshot 2024-01-17 at 4 00 56 AM

Issue example on latest Debian release.

@aeschli aeschli assigned roblourens and unassigned aeschli Jan 17, 2024
Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deepak1556 deepak1556 added this to the December / January 2024 milestone Jan 18, 2024
@deepak1556 deepak1556 enabled auto-merge (squash) January 18, 2024 18:54
@deepak1556 deepak1556 changed the title tweak check-requirements for calling ldconfig fix: tweak check-requirements for calling ldconfig Jan 18, 2024
auto-merge was automatically disabled January 18, 2024 19:01

Head branch was pushed to by a user without write access

@Leask
Copy link
Contributor Author

Leask commented Jan 18, 2024

@deepak1556 🤝 Done! Thanks for reminding me!

@Leask Leask requested a review from deepak1556 January 18, 2024 19:05
@deepak1556 deepak1556 merged commit 216a8e6 into microsoft:main Jan 18, 2024
@Leask
Copy link
Contributor Author

Leask commented Jan 19, 2024

Cool! 😄

@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connection to the host gets stuck at the stage of Downloading VS Code Server (Could not fetch remote environment).

6 participants