Skip to content

fix: memory leak in menubar#198052

Merged
sbatten merged 8 commits intomicrosoft:mainfrom
SimonSiefke:fix/memory-leak-menu-bar
Dec 21, 2023
Merged

fix: memory leak in menubar#198052
sbatten merged 8 commits intomicrosoft:mainfrom
SimonSiefke:fix/memory-leak-menu-bar

Conversation

@SimonSiefke
Copy link
Contributor

@SimonSiefke SimonSiefke commented Nov 12, 2023

Fixes #198051

Output with --measure instance-counts

{
  "instanceCounts": {
    "before": [
      {
        "name": "Menu",
        "count": 1
      }
    ],
    "after": [
      {
        "name": "Menu",
        "count": 1
      }
    ]
  },
  "isLeak": false
}

@bpasero bpasero requested review from bpasero and removed request for bpasero November 13, 2023 19:22
@bpasero
Copy link
Member

bpasero commented Nov 13, 2023

I think from here on I have to defer to Steven to review because I am not the original author of the code. Its not clear to me all the paths that lead to re-create or dispose of the custom menu...

Specifically, there seems to be calls to showCustomMenu without cleanupCustomMenu, so not clear to me if we still leak.

@sbatten sbatten enabled auto-merge (squash) December 19, 2023 00:18
@sbatten sbatten added this to the December / January 2024 milestone Dec 19, 2023
@sbatten sbatten merged commit 8a45b1b into microsoft:main Dec 21, 2023
@microsoft microsoft locked and limited conversation to collaborators Jun 11, 2024
@SimonSiefke SimonSiefke deleted the fix/memory-leak-menu-bar branch January 15, 2026 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

memory leak in menubar

4 participants