debug session: use queue to make sure debugee status get processed in correct order#180410
Merged
roblourens merged 1 commit intomicrosoft:mainfrom Apr 21, 2023
FlorentRevest:main
Merged
debug session: use queue to make sure debugee status get processed in correct order#180410roblourens merged 1 commit intomicrosoft:mainfrom FlorentRevest:main
roblourens merged 1 commit intomicrosoft:mainfrom
FlorentRevest:main
Conversation
… correct order Similarly to fed69ad, this adds a queue to serialize the processing of pause/continue events. Without this, if a pause and continue events are sent really fast, the pause handler will take longer to process than the continue handler and the state of the debugger UI will be paused when the debuggee is actually running. Fixes #180409
Contributor
Author
|
@microsoft-github-policy-service agree company="Google" |
roblourens
approved these changes
Apr 21, 2023
Member
roblourens
left a comment
There was a problem hiding this comment.
Good catch and analysis, thanks for the PR!
DonJayamanne
approved these changes
Apr 21, 2023
roblourens
added a commit
that referenced
this pull request
May 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to fed69ad, this adds a queue to serialize the processing of pause/continue events. Without this, if a pause and continue events are sent really fast, the pause handler will take longer to process than the continue handler and the state of the debugger UI will be paused when the debuggee is actually running.
Fixes #180409