Merged
Conversation
Fixes compile errors introduced by using the wrong variables with the toString method
beecc64 to
aef7cd6
Compare
andreamah
previously approved these changes
Feb 22, 2024
Tyriar
previously approved these changes
Feb 22, 2024
Member
Tyriar
left a comment
There was a problem hiding this comment.
Do we not have CI to prevent this on this repo?
lramos15
requested changes
Feb 22, 2024
Member
lramos15
left a comment
There was a problem hiding this comment.
We need to get CI for this, it's on the list.
Is there a way we can avoid the non null assertions?
Contributor
Author
|
Updating TypeScript could help, though won't get to that for a bit. |
Member
|
We can just remove |
Tyriar
approved these changes
Feb 22, 2024
connor4312
approved these changes
Feb 22, 2024
lramos15
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.