adding test users for testing in Azure #463
Conversation
|
@yitam can this be merged? |
| --for this script to work in Azure, use sqlcmd to connect to master database | ||
| IF NOT EXISTS (SELECT name FROM sys.sql_logins WHERE name = 'test_password') | ||
| BEGIN | ||
| CREATE LOGIN test_password WITH PASSWORD='! ;4triou'; |
There was a problem hiding this comment.
Issue with this line: test_password might exist in the database with a different password. This will cause the tests fail. Same applies for test_password2 and test_password2
There was a problem hiding this comment.
@yitam can we drop the test_password, and create it again? and at the end of the test, delete the pass too
There was a problem hiding this comment.
that was the original problem of running tests in parallel (dropping one another's test logins and passwords)
There was a problem hiding this comment.
@yitam can you generate password using random? and drop it at the end?
There was a problem hiding this comment.
unfortunately no, the specific test expects this particular password to make sure it fails and check for the appropriate error message
There was a problem hiding this comment.
what are those tests dependent on this pass? You can generate the pass in a parent setup script and then pass it on to dependent scripts
There was a problem hiding this comment.
The users and logins can be created inside the tests too, it does not have to be the setup scripts.
No description provided.