Fix debug buttons disabled issue: send StoppedEvent after StepResponse/ContinueResponse#227
Merged
testforstephen merged 3 commits intomasterfrom Sep 19, 2018
Merged
Fix debug buttons disabled issue: send StoppedEvent after StepResponse/ContinueResponse#227testforstephen merged 3 commits intomasterfrom
testforstephen merged 3 commits intomasterfrom
Conversation
…/ContinuedResponse Signed-off-by: Jinbo Wang <jinbwan@microsoft.com>
andxu
previously approved these changes
Sep 19, 2018
yaohaizh
reviewed
Sep 19, 2018
| return null; | ||
| }).join(); | ||
| } finally { | ||
| synchronized (this) { |
Contributor
There was a problem hiding this comment.
Avoid lock the whole object, use private object for lock.
andxu
approved these changes
Sep 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang jinbwan@microsoft.com
It fixes the bug microsoft/vscode-java-debug#411 and #134