Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 30, 2026

Summary of the Pull Request

Addresses code review feedback on #14121 by fixing inconsistent spacing in IDL attribute declarations for SaveImage and ExportContainer methods.

PR Checklist

  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated if needed and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated if needed
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

The SaveImage and ExportContainer method declarations in wslaservice.idl used inconsistent spacing in their attribute declarations and pointer types, deviating from the file's established conventions.

Changes:

  • [ in, unique ] IProgressCallback * ProgressCallback[in, unique] IProgressCallback* ProgressCallback
  • [in,out,unique] WSLA_ERROR_INFO * ErrorInfo[in, out, unique] WSLA_ERROR_INFO* ErrorInfo

Both declarations now match the compact spacing style used by all other methods in the interface:

  • No spaces inside attribute brackets
  • Asterisk adjacent to type name
  • Spaces after commas in attribute lists

Validation Steps Performed

Verified spacing consistency by comparing with existing method declarations (PullImage, LoadImage, ImportImage) that use the same parameter types.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update image save and export container implementation Fix IDL attribute spacing inconsistencies in SaveImage and ExportContainer Jan 30, 2026
Copilot AI requested a review from ptrivedi January 30, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants