Skip to content

[Java - Choice] Base classes porting#957

Merged
tellarin merged 7 commits intomicrosoft:masterfrom
southworks:southworks/java-choice/base
Nov 12, 2018
Merged

[Java - Choice] Base classes porting#957
tellarin merged 7 commits intomicrosoft:masterfrom
southworks:southworks/java-choice/base

Conversation

@joseques
Copy link
Contributor

@joseques joseques commented Nov 8, 2018

Proposed Changes

  • Ported Interfaces
  • Ported base classes structure with methods
  • Added library to Resource-Generator POM to include Choice resources

Test are passing correctly after the addition of the classes (skipped until fully ported)
image

tellarin
tellarin requested changes Nov 9, 2018
View reviewed changes
Copy link
Collaborator

@tellarin tellarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments.

Java/libraries/recognizers-text-choice/resource-definitions.json
},
{
"input": [
"French",
Copy link
Collaborator

@tellarin tellarin Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choice exists in other languages as well. Will they come in a follow up PR?

Copy link
Contributor Author

@joseques joseques Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tellarin Yes, they'll come in follow up PRs. We have the idea to make incremental changes, starting from the base structure up to the language specific extractors.

...nizers-text-choice/src/main/java/com/microsoft/recognizers/text/choice/ChoiceRecognizer.java Outdated
public class ChoiceRecognizer extends Recognizer<ChoiceOptions>{

public ChoiceRecognizer(String targetCulture, ChoiceOptions options, boolean lazyInitialization){
super(targetCulture,options,lazyInitialization);
Copy link
Collaborator

@tellarin tellarin Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Code standard. Missing whitespaces.

...nizers-text-choice/src/main/java/com/microsoft/recognizers/text/choice/ChoiceRecognizer.java Outdated
import com.microsoft.recognizers.text.ModelResult;
import com.microsoft.recognizers.text.Recognizer;

public class ChoiceRecognizer extends Recognizer<ChoiceOptions>{
Copy link
Collaborator

@tellarin tellarin Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Code standard. Missing whitespaces.

...nizers-text-choice/src/main/java/com/microsoft/recognizers/text/choice/ChoiceRecognizer.java Outdated

public IModel GetBooleanModel(String culture, boolean fallbackToDefaultCulture){
throw new UnsupportedOperationException();
//return GetModel<BooleanModel>(culture, fallbackToDefaultCulture);
Copy link
Collaborator

@tellarin tellarin Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this to avoid running tests in this version until it's more fully fleshed out?

Copy link
Contributor Author

@joseques joseques Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. The tests should be skipped until the recognizer is fully ported and the tests are passing correctly.

...-text-choice/src/main/java/com/microsoft/recognizers/text/choice/utilities/UnicodeUtils.java Outdated
import java.lang.Character;
import java.util.ArrayList;
import java.util.List;
public class UnicodeUtils{
Copy link
Collaborator

@tellarin tellarin Nov 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Code standard. Missing whitespaces and blank lines.

@joseques
Copy link
Contributor Author

joseques commented Nov 9, 2018

Hi @tellarin
Thanks for your review. I've pushed the requested changes!

@joseques
Copy link
Contributor Author

joseques commented Nov 9, 2018

In the previous commit I removed a duplicated method that was breaking the CI.

tellarin
tellarin approved these changes Nov 12, 2018
View reviewed changes
Copy link
Collaborator

@tellarin tellarin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modifications. I've resolved the new POM conflicts.

@tellarin tellarin merged commit ba48160 into microsoft:master Nov 12, 2018
@JuanAr JuanAr deleted the southworks/java-choice/base branch November 12, 2018 12:59
@joseques joseques mentioned this pull request Nov 12, 2018
Merged
iMicknl added a commit to iMicknl/Recognizers-Text that referenced this pull request Dec 28, 2018
@iMicknl
Squashed commit of the following:
c76344b 
commit 7b4ae83
Merge: 6749a6e 6086827
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Fri Dec 28 23:28:39 2018 +0100

    Merge branch 'master' of github.com:Microsoft/Recognizers-Text

commit 6086827
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Dec 27 00:36:37 2018 -0300

    Add script to process T4 templates (microsoft#1081)

    * Create script to process all T4 templates

    - use T5 transform tool
    - created script to iterate through all T4 files
    - tweak .ttinclude to use relative paths to reference assemblies and datafiles

    * Remove T4 Generator element to disable processing

    - Removing the <Generator>TextTemplatingFileGenerator</Generator> avoids errors when saving the T4 files
    - This is due to a conflict between how T4 are processed within VS in design-time and manually via build process

    * Execute BuildResources as part of Build

commit 3f91099
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Tue Dec 25 06:15:39 2018 -0300

    Fixed feature regex, added fix and hotfix regex (microsoft#1076)

    Fixed the configuration to start running tests over the feature/[anything] branches.
    Also added the fix/[anything] and hotfix/[anything] to the tests.

commit 22cf473
Author: Victor Grycuk <victor.grycuk@southworks.com>
Date:   Tue Dec 25 03:48:05 2018 -0300

    [Java][DateTime] Enable and Fix DateTimeModel with ExtendedTypes unit tests (microsoft#1072)

    * Enable and fix DatePeriodParser unit tests

    * Fix new BaseDatePeriodParser tests

    * Fix DateTime model tests

    * Fix new BaseDatePeriodParser tests

    * Fixes to BaseMergedDateTimeParser+related

    * Fix checkstyle issues

    * Fix CalendarMode tests

    * Update resources

    * Remove 'java' from 'Not Supported'

    * Add 'setText' and 'setType' to ExtractResult class

    * Change IDateTimeExtractor for IDateExtractor,

    Add getRangePrefixRegex() method

    * Add 'getDateExtractor' and 'getRangePrefixRegex'

    * Update BaseDateTimeAltExtractor.java

    * Update BaseDateTimeAltParser.java

    * Apply code style

commit c18e0b1
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Tue Dec 25 03:33:28 2018 -0300

    [Java][DateTime] Enable and Fix DateTimeModel with CalendarMode unit tests (microsoft#1063)

    * Enable and fix DatePeriodParser unit tests

    * Fix new BaseDatePeriodParser tests

    * Fix DateTime model tests

    * Fix new BaseDatePeriodParser tests

    * Fixes to BaseMergedDateTimeParser+related

    * Fix checkstyle issues

    * Fix CalendarMode tests

    * Update resources

commit 6749a6e
Merge: dbb185a 856ffe8
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Fri Dec 21 22:40:40 2018 +0100

    Merge branch 'master' of github.com:Microsoft/Recognizers-Text

commit 856ffe8
Author: Wujia Shi <45413381+WujiaShi@users.noreply.github.com>
Date:   Fri Dec 21 16:00:11 2018 +1100

    Fix "from 6 to 7" cannot be recognized under Calendar Mode (microsoft#1074)

    * Fix "from 6 to 7" cannot be recognized under calendar mode under dotnet

    * Add not supported information for java

    * Fix "from 6 to 7" cannot be recognized under Calendar Mode

    * Fix regex format

commit f77e297
Author: Malte Lantin <malantin@microsoft.com>
Date:   Fri Dec 21 03:07:08 2018 +0100

    Filter out certain German ein/1 ambiguity, correct incorrect spec (microsoft#1068)

commit 4db1357
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Thu Dec 20 22:16:55 2018 -0300

    [dotnet] Fix escape-char resolution in List (microsoft#1062)

    * Use string literal in list

    * Update resources

commit 779b8b4
Author: Wujia Shi <45413381+WujiaShi@users.noreply.github.com>
Date:   Fri Dec 21 12:09:20 2018 +1100

    Fix "one hour" and " half an hour" cannot be recognized in Chinese (microsoft#1071)

commit 1a36356
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Dec 20 22:08:36 2018 -0300

    [Java][DateTime] Enable and Fix DateTimeModel unit tests (microsoft#1066)

    * Enable and fix DatePeriodParser unit tests

    * Fix new BaseDatePeriodParser tests

    * Fix DateTime model tests

    * Fix new BaseDatePeriodParser tests

    * Fixes to BaseMergedDateTimeParser+related

    * Fix checkstyle issues

commit 1c85091
Author: Wujia Shi <45413381+WujiaShi@users.noreply.github.com>
Date:   Mon Dec 17 13:07:10 2018 +1100

    Add specs for "twenty-six", fix half an hour cannot be recognized (microsoft#1061)

commit c53d82d
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Fri Dec 14 06:28:35 2018 -0300

    Enable skipped java tests (microsoft#1060)

commit 88041b2
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Fri Dec 14 06:28:14 2018 -0300

    Fix escape-char resolution (microsoft#1059)

    * Delete escaped char, each platform should handle the conversion

    * Support escaped string - JS code generator

    * Update JS auto-generated code

    * Support escaped string - Java code generator

    * Update Java auto-generated code

    * Update code_writer.py to support escaped character

    * Update auto-generated Python code

    * Support escaped string - C# code generator

    * Update C# auto-generated code

commit 1690b08
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Fri Dec 14 06:24:01 2018 -0300

    [JS] Fix date initialization timezone (microsoft#1058)

    * Add time to end-date if missing

    * Update resources

commit cc4574b
Author: Wujia Shi <45413381+WujiaShi@users.noreply.github.com>
Date:   Thu Dec 13 16:34:01 2018 +0800

    Fix override warnings build under .Net in PT/ES/FR/GE/IT (microsoft#1055)

    * Fix overriding warnings build under dotnet in PT/ES/FR/GE/IT

    * Add a new file DummyTimeZoneParser to fix override warnings under dotnet

commit f7e1d45
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Dec 13 02:25:53 2018 -0300

    [Java][DateTime] Enable and fix BaseDatePeriodParser unit tests (microsoft#1057)

    * Enable and fix DatePeriodParser unit tests

    * Enabled notSupportedByDesign tests

    * Fix new BaseDatePeriodParser tests

commit ee6e138
Author: Malte Lantin <malantin@microsoft.com>
Date:   Wed Dec 12 10:39:14 2018 +0100

    Improve German DateTimeRange and TimeOfDay parsing (microsoft#1056)

    * Improve German TimeOfDay parsing

    * Support joined Day+TimeOfDay

    * Fix mistake in PMRegex

commit da05f21
Author: Malte Lantin <malantin@microsoft.com>
Date:   Tue Dec 11 03:21:17 2018 +0100

    Improve German DateTime recognition, mainly for Sets and DateTimeRanges (microsoft#1051)

    * Improve German DateTimeV2.Set recognition, correct and improve specs for Sets

    * Add comments around ambiguity of "morgen"

    * Improve German Holiday recognition and specs, add further Holidays

    * Add termin and telefonkonferenz to numberEndingPattern in german-datetime.yaml

    * Add missing MidafternoonRegex for German DateTime

    * Improve recognition for time of day (afternoon, morning, etc) for German, fix some issue with same day ("heute") in German

    * Add 'zwo' as a commonly used alternative for 'zwei'

    * Add ambiguity filter for German

    * Correct "from" token for TimePeriod extraction in German

    * Improve parsing of present day references by adding more German terms

    * Improve and correct German DateTime specs, align expected extraction to English

commit b1a6411
Author: Wujia Shi <45413381+WujiaShi@users.noreply.github.com>
Date:   Tue Dec 11 10:16:40 2018 +0800

    Fix number ranges wrongly extracted as datetime ranges (microsoft#1044)

commit 1ea67b5
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Mon Dec 10 17:35:40 2018 +0800

    Minor English YAML edits in currency and datetime (microsoft#1053)

    Minor edits as workaround in Currency. A more complete solution will come in the future.
    Regeneration of missing resources in other platforms.

commit bafc751
Author: Hans Bakker <hansmbakker+github@gmail.com>
Date:   Mon Dec 10 07:10:52 2018 +0100

    Migrate SimpleConsole to .net core (microsoft#1043)

    * Migrate SimpleConsole to .net core

commit 84dbb46
Author: Darío Hereñú <magallania@gmail.com>
Date:   Mon Dec 10 01:29:15 2018 -0300

    Fix typo on intro README (microsoft#1052)

commit 63f5fbf
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Mon Dec 10 11:55:43 2018 +0800

    Fix wrong boundary of extracted subentities in DateTimeModelSplitDateAndTime (microsoft#1049)

    * Fix wrong boundary of sub-entities and a few typos

commit 3c12ba5
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Fri Dec 7 08:51:03 2018 -0300

    Fix Merged parser tests (microsoft#1048)

commit f9c42c0
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Fri Dec 7 08:33:15 2018 -0300

    Fix DateTime parser tests (microsoft#1046)

commit 6c427c4
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Fri Dec 7 08:29:25 2018 -0300

    Enable DateTimePeriod parser tests (microsoft#1047)

commit 277f95e
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Fri Dec 7 08:20:38 2018 -0300

    Fix TimePeriod parser tests (microsoft#1045)

commit 7a069ac
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Fri Dec 7 00:36:22 2018 -0300

    [Java][DateTime] Enable and Fix DateParser unit tests (microsoft#1042)

    * Fix Duration parser tests

    * Fix Date parser tests

commit ba7102c
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Dec 6 23:29:19 2018 -0300

    Enabled TimeZoneParser skipped tests (microsoft#1041)

commit 7e5d768
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Dec 6 23:29:00 2018 -0300

    Enabled MergedExtractor skipped tests (microsoft#1040)

commit c5d1f8d
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Thu Dec 6 22:58:18 2018 -0300

    Fix Duration parser tests (microsoft#1039)

commit a537601
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Thu Dec 6 22:57:19 2018 -0300

    Fix DateTime extractor tests (microsoft#1038)

commit 743b265
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Thu Dec 6 22:56:46 2018 -0300

    Fix DatePeriod extractor tests (microsoft#1037)

commit 333c4ad
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Dec 6 01:28:29 2018 -0300

    [Java][DateTime] Enable and Fix TimeZoneExtractor unit tests (microsoft#1036)

    * Fix and enable TimeZoneExtractor skipped tests

commit 74e2f6d
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Dec 6 00:30:54 2018 -0300

    [Java][DateTime] Enable DurationExtractor skipped tests (microsoft#1035)

    * Enable DurationExtractor skipped test

    * Update DurationExtractor.json

commit 6b85098
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Thu Dec 6 00:01:06 2018 -0300

    [CI][Java] Make resource regeneration part of CI build (microsoft#1034)

    * Update Java resources

    * Generate Java resources in each build

    * Fix resources issue in Java

commit dad8a32
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Thu Dec 6 10:57:31 2018 +0800

    Move some language-specific hard-coded strings to YAML files (microsoft#1028)

commit 82a75de
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Wed Dec 5 15:40:50 2018 +0800

     Fix cases like 'one year and half' being wrongly resolved as 'one year' (microsoft#1032)

    * Fix wrong resolution of cases like 'one year and half'

    * Add few test cases to specs

commit 58839ef
Author: Mu Guo <guom08@gmail.com>
Date:   Tue Dec 4 16:45:03 2018 +0800

    Refactor AM/PM related regexes and add support for "p . m ." (microsoft#1029)

    * Add support for extra spaces.

    * Refactor Am/Pm related regexes

    * Unify the Regex organization across languages

commit 630ce12
Author: Wujia Shi <45413381+WujiaShi@users.noreply.github.com>
Date:   Mon Dec 3 16:48:52 2018 +0800

    Fix handling "later"/"earlier" in relative time ranges (microsoft#1025)

commit ca47985
Author: Mu Guo <guom08@gmail.com>
Date:   Mon Dec 3 14:54:35 2018 +0800

    Make "week of" cases consistency (microsoft#1024)

    * Fix "last week of 2019" case

    * Replace WeekDayCount constant

    * Refactor code to follow the ISO week definition

    * Make "week of month", "week of year" consistent

    * Support "week of month year" cases and update the specs

commit ca98736
Author: Mu Guo <guom08@gmail.com>
Date:   Mon Dec 3 13:45:04 2018 +0800

    Support Timezone in TimeRange and DateTimeRange (microsoft#1019)

    * Support Timezone in TimeRange and DateTimeRange if Preview enabled

    * Add missing specs

commit 5a8cccc
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Mon Dec 3 02:00:09 2018 -0300

    [Java] Apply linting format and enable CheckStyle rules (microsoft#1021)

    * Fix recognizers-text CheckStyle issues

    * Fix recognizers-text-choice CheckStyle issues

    * Fix recognizers-text-date-time (english extractor) CheckStyle issues

    * Fix recognizers-text-date-time (english parser) CheckStyle issues

    * Fix recognizers-text-date-time (base extractor) CheckStyle issues

    * Fix recognizers-text-date-time (base parsers) CheckStyle issues

    * Fix recognizers-text-date-time (utilities) CheckStyle issues

    * Enable CheckStyle error

commit 92dc74b
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Fri Nov 30 15:43:52 2018 +0800

    Cleaning up German skipped tests (microsoft#1022)

    * Cleaning up German skipped tests.

    * Minor PR cleanup.

commit cd2da47
Author: Mu Guo <guom08@gmail.com>
Date:   Fri Nov 30 15:24:35 2018 +0800

    Fix recognition for cases like "11/20, 11/22 or 11/25" (microsoft#1018)

    * Fix the issue in ComplexCalendarMode

    * Add specs for EnglishOthers

commit bcaa390
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Nov 30 02:23:40 2018 -0300

    Enable and fix DatePeriodParser unit tests (microsoft#1020)

commit f2a7b86
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Fri Nov 30 13:08:29 2018 +0800

    Fix wrong parse result for “end of the day” and support "EOD", "end of day" and the abbreviation of DatePeriod like "eoy (end of year)" (microsoft#1001)

    * Fix wrong parse result for 'end of the day', support 'eod', 'eoy' and 'end of day'

    * Support the abbreviation of DatePeriod, like eoy (end of year)

    * Disable cases like "end of the day" in Java as the new implementation for these cases are not supported currently

commit 1633233
Author: Enzo Cano <enzo.cano@southworks.com>
Date:   Thu Nov 29 01:10:59 2018 -0300

    [Java][Datetime] Port DateTimeModel from C# to Java (microsoft#1017)

    * Add DateTimeModel

    * Add model tests and disable ones not currently supported.

commit 36c0fa2
Author: Mu Guo <guom08@gmail.com>
Date:   Wed Nov 28 13:00:28 2018 +0800

    Fix wrong recognition for "next week - wednesday" (microsoft#1016)

commit 5a40503
Author: Malte Lantin <malantin@microsoft.com>
Date:   Wed Nov 28 02:09:55 2018 +0100

    Improve German DateTimeV2.Set recognition, correct and improve specs for Sets (microsoft#1013)

commit 814a825
Author: David Favretto <david.favretto@southworks.com>
Date:   Tue Nov 27 22:08:12 2018 -0300

    [Java][DateTime] Fix DateExtractor's skipped test (microsoft#1015)

    * Ported logic for skipped test 'I will leave in 3 weeks'

    * Fix linting warnings

commit c1076b9
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Nov 27 22:07:34 2018 -0300

    Fix BaseSetParser unit tests (microsoft#1014)

commit aadf154
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Nov 27 22:05:42 2018 -0300

    [Java][Datetime] Port BaseMergedParser from C# to Java (microsoft#1012)

    * Port BaseMergedParser to to Java

commit 8a63e27
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Tue Nov 27 22:02:43 2018 -0300

    Fixed DateTimePeriodExtractor tests (microsoft#1011)

commit 7fb2088
Author: Mu Guo <guom08@gmail.com>
Date:   Sun Nov 25 10:35:01 2018 +0800

    Fix issue with entity boundaries that wrong result in too long entities (microsoft#1003)

    * Fix missing boundary check and regex issues

    * Refactor ExactMatch judgement using Extension method

    * Refactor regex match related code

commit 1121d12
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Sun Nov 25 02:11:39 2018 +0100

    [NL NumberWithUnits] Various Unit fixes in .NET (microsoft#1005)

    * Change ‘Cubic foot’ to ‘Cubic meter’

    * Fix currency cases

    * Add missing culture string

    * Re-generate definitions for C#

commit 8df5eef
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Sat Nov 24 16:43:57 2018 +0800

    Minor cleanup and removal of diff file (microsoft#1010)

    * Minor cleanup and removal of diff file.

    * Update EnglishDateTimePeriodExtractorConfiguration.java

commit f970eb7
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sat Nov 24 01:04:33 2018 -0300

    [Java][Datetime] Port BaseSetParser from C# to Java (microsoft#1009)

    * Port BaseSetParser to Java

commit c13c48e
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sat Nov 24 00:37:46 2018 -0300

    [Java][Datetime] Port BaseDateTimePeriodParser from C# to Java (microsoft#1008)

    * Port BaseDateTimePeriodParser to Java

    * Merge TimePeriodParser

commit 1eb0b23
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Sat Nov 24 00:13:27 2018 -0300

    [Java][Recognizers-text] Apply new linting rules to number & number-with-units (microsoft#1007)

commit 18fc290
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sat Nov 24 00:12:12 2018 -0300

    [Java][Datetime] Port BaseDateTimeParser from C# to Java (microsoft#1006)

    * Port BaseDateTimeParser to Java

commit b1ef206
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Sat Nov 24 00:02:58 2018 -0300

    [Java][Recognizers-Text] Linting rules update (microsoft#1004)

    Modified linting rules:
    * Local variable, parameter and catch parameter name must match the regex "^[a-z][a-zA-Z0-9]*$"
    * Variable declaration distance change from 5 to 10
    * The operators "&&", "||" and "?" must be at the end of the line when the line is split into multiple lines
    * No white spaces after "typecast" added

commit 0d7a474
Author: JuanAr <juan.arguello@southworks.com>
Date:   Sat Nov 24 00:00:45 2018 -0300

    [Java][Datetime] Port BaseTimePeriodParser from C# to Java (microsoft#1000)

    * Port BaseTimePeriodParser to Java

commit d65f125
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Nov 23 23:56:17 2018 -0300

    [Java][Datetime] Port BaseDatePeriodParser from C# to Java (microsoft#998)

    * Port BaseDatePeriodParser to java

commit 104547f
Author: Malte Lantin <malantin@microsoft.com>
Date:   Sat Nov 24 03:51:35 2018 +0100

    Update German DateTime definitions, specs, add new holiday parser for German holidays (microsoft#992)

    * Change first test cases for German DateTime for correct semantic

    * Semantic changes to german DateTime test cases

    * Add custom holiday parser for German and local holidays for German (Germany, Austria, Switzerland)

    * Add additional German datetime regexes

    * Fix bugs in German-DateTime.yaml and add more regex

    * Added calculation of German variable holidays

    * Change check of weekday to work for languages other than English

    * Bugfix half year Regex

    * Fix regex for DateExtractor

    * Fix tests and improve test coverage for DateTime German

    * Improve test coverage for DurationExtractor in German and improve regex

    * Update with latest DateTimeDefinitions for German

    * Adjustments to specs or adding comment tags for NotSupported cases.

    * Refactor the Holiday Parser for German

    * Add additional test specs for German and clean spec file

    * Add culture invariant parsing of strings to double in BaseDurationParser

    * Improve German holiday recognition regex for Christmas

    Co-authored-by: Malte Lantin <malantin@microsoft.com>
    Co-authored-by: Alexander Misera <alexander.misera@web.de>

commit dbb185a
Merge: 54e7ef0 289a54f
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Thu Nov 22 22:39:59 2018 +0100

    Merge branch 'master' of github.com:Microsoft/Recognizers-Text

commit 289a54f
Author: pedrovon <44889713+pedrovon@users.noreply.github.com>
Date:   Thu Nov 22 18:06:27 2018 +0800

    Add cases for DateTimePeriodExtractor & DateTimePeriodParser in Spanish (microsoft#1002)

    * Add cases for DateTimePeriodExtractor in Spanish

    * Add cases for DateTimePeriodParser in Spanish

commit 2adad01
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Nov 22 03:00:39 2018 -0300

    [Java][Datetime] Port BaseHolidayParser from C# to Java (microsoft#999)

    * Port BaseHolidayParser to Java

    * Minor reformatting in BaseHolidayParser, BaseHolidayParserConfiguration, and DateTimeParserTest

commit 785abca
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Nov 22 02:44:21 2018 -0300

    [Java][Datetime] Port BaseTimeParser from C# to Java (microsoft#997)

    * Port BaseTimeParser to Java

    * Update EnglishTimeParserConfiguration.java

    * Indentation fix in DateTimeParserTest.java

commit 58cebb9
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Nov 22 00:28:37 2018 -0300

    [Java][Datetime] Port BaseTimeZoneParser from C# to Java (microsoft#996)

    * Port BaseTimeZoneParser to Java

    * Skipped unsupported tests in java

    * Codestyle formatting

    * Fix indentation in DateTimeParserTest.java

commit ac1744b
Author: pedrovon <44889713+pedrovon@users.noreply.github.com>
Date:   Thu Nov 22 11:04:52 2018 +0800

    Add cases for TimePeriodExtractor & TimePeriodParser in Spanish (microsoft#995)

    * Add cases for TimePeriodExtractor in Spanish

    * Add cases for TimePeriodParser in Spanish

commit d7e17f7
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Nov 20 23:12:21 2018 -0300

    [Java][Datetime] Port BaseDateParser from C# to Java (microsoft#994)

    * Port BaseDateParser from C# to Java

commit 249d6fe
Author: pedrovon <44889713+pedrovon@users.noreply.github.com>
Date:   Tue Nov 20 16:00:16 2018 +0800

    Adding sentences in DatePeriodParser in Spanish (microsoft#993)

commit dd291b7
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Mon Nov 19 23:05:30 2018 -0300

    Applied linting format to several .java files (microsoft#989)

commit 0330f06
Author: Mu Guo <guom08@gmail.com>
Date:   Mon Nov 19 14:39:47 2018 +0800

    Support cases like "next Monday or next Tuesday" in ComplexCalendar mode (microsoft#978)

    * Support cases like "next Monday or next Tuesday" in ComplexCalendar mode

    * Refactor code according to the comments

    * Refactor code to use common method in BaseDateTimeAltExtractor

commit 8f4b049
Author: pedrovon <44889713+pedrovon@users.noreply.github.com>
Date:   Mon Nov 19 14:34:12 2018 +0800

    Adding new DatePeriodExtractor specs in Spanish (microsoft#991)

commit 9fb7b52
Author: JuanAr <juan.arguello@southworks.com>
Date:   Mon Nov 19 00:29:41 2018 -0300

    [Java][Datetime] Port BaseDurationParser from C# to Java (microsoft#990)

    * Port BaseDurationParser from C# to Java

    * Temporarily removed unused/non-ported parsers

    * Temporarily skipped unsupported test in java

commit 74caf58
Author: Joe <quesjose1@gmail.com>
Date:   Mon Nov 19 00:27:17 2018 -0300

    [Java][Choice] Enable tests, port base recognizer and English extractor from C# to Java (microsoft#987)

    * Port recognizer, models logic and english boolean extractor

    * WIP Fixes and enabled tests

    * Fix choice extractor

commit 270cb21
Author: JuanAr <juan.arguello@southworks.com>
Date:   Mon Nov 19 00:25:39 2018 -0300

    [Java][Datetime] Port BaseMergedExtractor & BaseDateTimeAltExtractor from C# to Java (microsoft#984)

    * Port BaseMergedExtractor from C# to Java

commit c9fff7f
Author: Gaspar Acevedo Zain <43762887+GasparAcevedoZainSouthworks@users.noreply.github.com>
Date:   Mon Nov 19 00:22:08 2018 -0300

    *Applied linting format to several .java files (microsoft#986)

    *linting-rules.xml:
    + property allowedAbbreviationLength changed from 1 to 4
    + property VariableDeclarationUsageDistance was setted to 5
    + Delete deprecated value from linting-rules.xml (LeftCurlyBraces->maxLineLength) (+14 squashed commit)

commit c560e90
Author: JuanAr <juan.arguello@southworks.com>
Date:   Mon Nov 19 00:20:33 2018 -0300

    [Java][Datetime] Port BaseSetExtractor from C# to Java (microsoft#983)

    * Port BaseSetExtractor from C# to Java

commit 4153d7c
Author: JuanAr <juan.arguello@southworks.com>
Date:   Mon Nov 19 00:16:58 2018 -0300

    [Java][Datetime] Port BaseDateTimePeriodExtractor from C# to Java (microsoft#981)

    * Port BaseDateTimePeriodExtractor from C# to Java

    * Rebased with master and fixed code format

commit 0188fa9
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Fri Nov 16 20:06:25 2018 +0800

    Refactor/comment NumberWithUnitTokenzier (microsoft#985)

commit e6b44f4
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Nov 16 03:24:48 2018 -0300

    [Java][Datetime] Port BaseDateTimeExtractor from C# to Java (microsoft#976)

    * Port BaseDateTimeExtractor from C# to Java

    * Disable tests still not supported in java

commit 732f08c
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Nov 16 02:45:11 2018 -0300

    [Java][Datetime] Port BaseTimePeriodExtractor from C# to Java (microsoft#970)

    * Port BaseTimeZoneExtractor from C# to Java

    * Port BaseTimeExtractor from C# to Java

    * Port BaseTimePeriodExtractor from C# to Java

commit aa95e51
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Nov 16 02:10:18 2018 -0300

    [Java][Datetime] Port BaseTimeExtractor from C# to Java (microsoft#966)

    * Port BaseTimeExtractor from C# to Java

commit 7306e50
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Nov 16 01:41:55 2018 -0300

    Fix failed unit tests count in summary table (microsoft#982)

commit 1e47e5b
Author: Gustavo Calheiros <gustavorlc@gmail.com>
Date:   Fri Nov 16 05:40:55 2018 +0100

    [dotnet][Datetime][Japanese] Initial .net support for datetime in japanese (microsoft#975)

    * Implementing DateTime for japanese and enabling UTs + implementing new ones regarding "date range".

    * Removing all "RegexOptions.IgnoreCase" (no need in japanese)

    * Removed suffix "Jap" from files.

commit ab9e107
Author: JuanAr <juan.arguello@southworks.com>
Date:   Fri Nov 16 01:32:14 2018 -0300

    Port BaseTimeZoneExtractor from C# to Java (microsoft#964)

commit dd37801
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Thu Nov 15 18:39:55 2018 +0800

    Improve the performance of currency (microsoft#968)

    * Improve the performance of Currency extractor

    * Refactoring according to review comments

commit 19670a9
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Wed Nov 14 20:01:45 2018 -0800

    Fixing PR merge mistake with Java extractor tests. (microsoft#977)

commit 9f09391
Author: JuanAr <juan.arguello@southworks.com>
Date:   Thu Nov 15 00:33:23 2018 -0300

    [Java][Datetime] Port BaseDatePeriodExtractor from C# to Java (microsoft#959)

    * Port BaseDatePeriodExtractor from C# to Java

    * Disable unsupported test case for Java

commit cd3d794
Author: Joe <quesjose1@gmail.com>
Date:   Tue Nov 13 21:49:11 2018 -0300

    [Java][Choice] Port base parsers and extractors from C# to Java  (microsoft#971)

    * Parsers base classes port

    * Extracted public class to own file & minor var names fixes

    * Refactor for lint rules compliance and improve readability

commit dcfbc88
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Nov 13 21:46:38 2018 -0300

    Port BaseHolidayExtractor from C# to Java (microsoft#963)

commit 042896f
Author: JuanAr <juan.arguello@southworks.com>
Date:   Tue Nov 13 20:59:16 2018 -0300

    [Java][Datetime] Port BaseDateExtractor from C# to Java (microsoft#958)

    * Added Port BaseDateExtractor from C# to Java

    * Removed Pattern.CASE_INSENSITIVE when it doesn't break Java tests

commit a7520e6
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Mon Nov 12 23:58:39 2018 -0800

    - Java 8 doesn't support lookbehinds with no max length. Added method in RegExpUtility to make regexes safe for Java 8; (microsoft#972)

    - Re-gen Java resources;
    - Code formatting.

commit f5cf7b0
Author: Joe <quesjose1@gmail.com>
Date:   Mon Nov 12 23:41:50 2018 -0300

    [Java] Add CheckStyle to ensure code standardization (microsoft#965)

    * Add POC for linter

    * Added information about linting tool in README

commit 039f49c
Author: Mu Guo <guom08@gmail.com>
Date:   Mon Nov 12 16:25:40 2018 +0800

    Support cases like "the day after" and "the day before" (microsoft#956)

    * Support cases like "the day after" and "the day before"
    * Refactor the Code-Writers and Generate resources in JavaScript and Python

commit e83d8e8
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Sun Nov 11 23:53:36 2018 -0800

    Minor cleanup in QueryProcessor in C#, method to check Java version, and code format in Python resource code writer. (microsoft#967)

commit ba48160
Author: Joe <quesjose1@gmail.com>
Date:   Mon Nov 12 00:28:30 2018 -0300

    [Java - Choice] Base classes porting (microsoft#957)

    * WIP for base classes port

    * Fixed implements and base classes

    * Modified Resource-Generator POM to include Choice resources

commit ca137ac
Author: JuanAr <juan.arguello@southworks.com>
Date:   Mon Nov 12 00:24:37 2018 -0300

    [Java][Datetime] Port BaseDurationExtractor from C# to Java (microsoft#955)

    * Add DateTime structure

    * Add DateTime base classes and English duration extractor implementation

    * Add English duration extractor tests

    * Fix test skipped status report

commit 08eac17
Author: pedrovon <44889713+pedrovon@users.noreply.github.com>
Date:   Fri Nov 9 16:08:22 2018 +0800

    Add NumberRangeModel json specs in Spanish (microsoft#961)

    * Add NumberRangeModel specs in Spanish

commit 996c150
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Thu Nov 8 23:09:12 2018 -0800

    Fixing GitHub security vulnerabilities warning in JS. (microsoft#960)

commit 4e0f6d9
Author: Mu Guo <guom08@gmail.com>
Date:   Fri Nov 9 14:43:36 2018 +0800

    Support cases like "Dec/2018" and fix wrong resolution for "Dec-2018" (microsoft#954)

commit 10064e8
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Thu Nov 8 22:04:06 2018 -0800

    Multiple changes for consistency in response and avoid lowercase everywhere (microsoft#953)

    - Standardizing all output for consistency;
    - Avoid spread of regexes doing lowercases unecessarily;
    - Moving common regex to base resources;
    - Behaviour was not changed, where case-sensitive before, it remains the same;
    - Fix some typos in French resources;
    - Refactor renames for a little more code clarity;
    - Adding Java env debug info in CI build.

commit 45681a6
Author: Mu Guo <guom08@gmail.com>
Date:   Tue Nov 6 17:38:05 2018 +0800

    Fix incorrect cases like "05-Aug-2015" and "Monday morning 10am to 12pm" (microsoft#947)

    * Fix parsing date time periods.

    * Update Javascript and Python resources.

    * Refactoring according to feedback and offline discussions.

commit 6842ba9
Author: Mu Guo <guom08@gmail.com>
Date:   Tue Nov 6 15:44:42 2018 +0800

    Fix wrong recognition for "10/1 - 11/7" (microsoft#931)

    * .Net, Javascript, and Python resource changes

    * .Net support

    * Refactor to new interface and refactor timex related code

commit 38f5203
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Sun Oct 28 23:23:08 2018 -0700

    Minor PyPI package definition changes. (microsoft#943)

commit 13980a9
Author: Hugo van Rijswijk <hugo.v.rijswijk@gmail.com>
Date:   Mon Oct 29 07:21:42 2018 +0100

    Add some Dutch speaking language and common names to the Dutch models (microsoft#942)

    * Add some Dutch speaking language and common names to the Dutch models (not supported yet)

commit af99a09
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Mon Oct 29 13:24:01 2018 +0800

    Refactor TOD hardcoded strings in all languages (microsoft#939)

commit 2d69c7a
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Fri Oct 26 03:08:18 2018 -0700

    Formatting for consistency, adding TODOs, and minor regex changes. (microsoft#940)

commit 2b763d0
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Thu Oct 25 15:30:19 2018 +0800

    Refactor hardcoded strings and renames (microsoft#932)

    * Refactor hard-coded strings and renames

commit f3b53d4
Author: Yifan Sun <pkuyifansun@gmail.com>
Date:   Thu Oct 25 10:49:47 2018 +0800

    GUID enhancement with more formats and score function (microsoft#937)

    * Support more GUID formats and add score function

commit db9e4ff
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Wed Oct 24 05:01:24 2018 -0700

     Standardizing init to follow English (except in CJK) (microsoft#936)

    * Standardizing init to follow English (except in CJK for now).
    Plus minor renames/cleanup.

    * Re-gen resources.

commit ba3e12e
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Wed Oct 24 02:50:05 2018 -0700

    Fix "cent" wrongly extracted as currency from "pour cent"  (microsoft#934)

    * Renames for ambiguity filter and moving loading method to utils class in Definitions project.

    * Adding filter in single unit.

    * Fix typo is test spec tag.

commit 9af1fb1
Author: Yifan Sun <pkuyifansun@gmail.com>
Date:   Wed Oct 24 16:50:51 2018 +0800

    Support phone numbers start or end with dash or have a single bracket (microsoft#935)

    * Add support for phone numbers start or end with dash or have a single bracket

commit 0cf7f40
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Wed Oct 24 15:38:56 2018 +0800

    Fix wrong resolution results for cases like 'from 10/1 to 11/7' in Ja… (microsoft#933)

    * Fix wrong resolution results for cases like 'from 10/1 to 11/7' in Javascript and Python
    * Add specs to English DateTime

commit 4712dd0
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Wed Oct 24 10:53:25 2018 +0800

    Update README.md

commit 7c41bbd
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Wed Oct 24 10:36:21 2018 +0800

    Update README.md

commit 46a0649
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Wed Oct 24 10:26:52 2018 +0800

    Adding entity support table to main README

commit 6cdfd95
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Tue Oct 23 02:41:39 2018 -0700

    Support for Dutch in JavaScript Choice recognizer. (microsoft#929)

commit a2b914d
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Tue Oct 23 00:25:02 2018 -0700

    Prep for NPM packages v1.1.4 (microsoft#928)

commit 505078e
Author: Sanxing Chen <mestayinloves@gmail.com>
Date:   Tue Oct 23 12:24:34 2018 +0800

    Add missing comment and fix typo (microsoft#927)

    - minor: add /.vscode to gitignore

commit 22a8b76
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Mon Oct 22 18:42:52 2018 -0700

    Minor renames and formatting. (microsoft#926)

commit b0e50cb
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Tue Oct 23 02:22:09 2018 +0200

    [NL] Optimize BooleanModel & NumberWithUnitsModel (microsoft#898)

    * Add support + testcase for -jarige & jarige

    * Add 元 as a supported symbol for reminbi

    * Regenerate definitions and add testcases for BooleanModel

    * Add fix for microsoft#800

    * Add support for lowercase units

    * Add start / end index to tests

    * Bugfix add ‘NotSupportedByDesign’ to new case

    * Change Dutch patterns to reflect the English patterns

    * Generate files for .NET and change test

commit 35cf8cc
Author: Guoxin Wang <wgx998877@qq.com>
Date:   Tue Oct 23 08:16:03 2018 +0800

    Fix timezone extractor bug and improve memory performance of match engine (microsoft#921)

    * Fix timezone bug and improve the memory performance of match engine

commit ed4719d
Author: Sanxing Chen <mestayinloves@gmail.com>
Date:   Tue Oct 23 08:14:00 2018 +0800

     Add build.sh in Python project for shell users and fix a typo (microsoft#922)

    * Add build.sh in Python project for shell users

commit 54e7ef0
Merge: c85e46a b0f5cdf
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Mon Oct 22 19:12:14 2018 +0200

    Merge branch 'master' of https://github.com/Microsoft/Recognizers-Text

commit b0f5cdf
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Mon Oct 22 13:41:52 2018 +0800

    Update README.md

commit 062be2e
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Mon Oct 22 13:34:32 2018 +0800

    Update README.md

commit c6b0b0c
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Mon Oct 22 13:24:48 2018 +0800

    Update CONTRIBUTING.md

commit 97056cf
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Mon Oct 22 13:24:16 2018 +0800

    Update CONTRIBUTING.md

commit 028203f
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Thu Oct 18 03:26:17 2018 -0700

    Add missing resource file references to .NET project (microsoft#919)

    * Minor fix to Definitions csproj.

    * Solution edit.

commit cfe12bf
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Thu Oct 18 17:59:50 2018 +0800

    Add python support to fix dimension wrongly recognized inside time (microsoft#918)

    * Add python support to fix dimension wrongly recognized inside time

commit a05d98e
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Thu Oct 18 15:04:40 2018 +0800

    Refactor: move repeated regexes to Base-DateTime.yaml (microsoft#917)

commit d350b91
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Thu Oct 18 10:47:45 2018 +0800

    Fix wrong parse result for '2:00 PM', '00 PM' is not dimension (microsoft#895)

    * Fix wrongly recognized dimension inside a time entity

commit f76e661
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Thu Oct 18 10:38:00 2018 +0800

    Fix year wrongly recognized inside a GUID (microsoft#911)

    * Fix wrong extract single year which is surrounded by '-' at both sides (e.g. inside a GUID)

commit 79affe3
Author: Vedansh Priyadarshi <22790213+pristineVedansh@users.noreply.github.com>
Date:   Wed Oct 17 14:54:47 2018 +0530

    Updated a punctuation (microsoft#915)

commit b0d7282
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Wed Oct 17 02:09:33 2018 -0700

    Minor update to informal tz names dictionary (microsoft#914)

commit fea54a9
Author: Mu Guo <guom08@gmail.com>
Date:   Wed Oct 17 16:58:42 2018 +0800

    Fix wrong recognition of Currency pieces as DateTime (microsoft#909)

    * Fix wrongly recognition the currency as DateTime entity in Spanish

    * Fix English and Portuguese

    * Partially fix French and German

    * Refine the Language Mapping method

commit 25a4cb9
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Wed Oct 17 00:22:25 2018 -0700

    Workaround as some languages can use different decimal separators depending on location (microsoft#912)

    * Temp. workaround as some languages can use different decimal separators depending on location.
    For example, Spanish in Puerto Rico uses dot and not comma as decimal separator.

    * - Adding workaround for JS, PY, and Java;
    - Regen Java resources and fix build breaks;
    - Regen Python resources.

    * Temporarily disabling test specs as it looks like an issue in the test assert.

    * Temporarily disabling test specs as it looks like an issue in the test assert.

commit 99f16f3
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Tue Oct 16 23:45:36 2018 -0700

    Fixing vulnerabilities detected by GitHub. (microsoft#913)

commit c22f145
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Tue Oct 16 01:59:37 2018 +0200

    Fix ‘honderduizend’ and ‘honderd duizend’ (microsoft#910)

    Enable testcases for .NET and add missing testcases

commit c85e46a
Merge: bf46025 7cd735b
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Mon Oct 15 23:41:15 2018 +0200

    Merge branch 'master' of https://github.com/iMicknl/Recognizers-Text

commit 7cd735b
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Fri Oct 12 16:59:28 2018 +0800

    Support extract cases like '上午', '下午' in Chinese DateTime (microsoft#907)

    * Support extract cases like '上午', '下午' in Chinese DateTime

    * Support extract cases like '上午' in JS and Python

commit 72de641
Author: Mu Guo <guom08@gmail.com>
Date:   Thu Oct 11 14:31:57 2018 +0800

    Improve recognition of Url and Email (microsoft#905)

    * Fix support for some Url and Email

commit e0e652d
Author: Felaray <felaray@gmail.com>
Date:   Thu Oct 11 10:33:13 2018 +0800

    Github Issue microsoft#904 (microsoft#906)

commit 198bf96
Author: Mu Guo <guom08@gmail.com>
Date:   Tue Oct 9 16:09:30 2018 +0800

    Fix compound duration timex (microsoft#903)

commit 4d499d0
Author: Mu Guo <guom08@gmail.com>
Date:   Tue Oct 9 16:07:21 2018 +0800

     Support extract cases like "2:00 PM", "8:05 am" in Chinese Datetime (microsoft#899)

    * Support extract cases like "2:00 PM", "8:05 am" in Chinese DateTime

    * Add support for JavaScript

commit 15ac9af
Author: Felaray <felaray@gmail.com>
Date:   Tue Oct 9 14:30:10 2018 +0800

     [CN DateTime] Extend the recognition for traditional Chinese (microsoft#902)

    * [CN DateTime] Extend datetime recognition for "後|之後|以後"

commit bf46025
Author: Mick Vleeshouwer <mick@imick.nl>
Date:   Sat Sep 29 00:03:14 2018 +0200

    Change PM to PB and add missing cases from English

commit 1f9ceaf
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Fri Sep 28 03:12:36 2018 -0700

    Fixing DateTime PT regexes for days of week. (microsoft#894)

commit 74658ef
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Fri Sep 28 17:58:10 2018 +0800

    Add 元 as a supported symbol for reminbi in the English yaml (microsoft#893)

commit 4698d62
Author: Mu Guo <guom08@gmail.com>
Date:   Fri Sep 28 16:33:49 2018 +0800

    Correct parsing results for "from March to May", "3月和5月之间" (microsoft#892)

    * Fix wrong DateRangeTimex in resolution values for English

    * Support "MonthToMonth" DateRange in Chinese DateTime

commit c06b310
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Fri Sep 28 16:05:40 2018 +0800

    Fix wrong parse result for '从二零一六年至二零一八年' in Python and JavaScript (microsoft#891)

commit 864534f
Author: Matt Shim <shimm@oregonstate.edu>
Date:   Thu Sep 27 04:41:44 2018 -0700

    French choice recognizer, first pass (microsoft#812)

    * French-choice first pass

    * Added french specs boolean model

    * Adding/fixing French and German Choice

    * JS code fixes and Unicode escapes

commit 1a40c1e
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Wed Sep 26 22:12:23 2018 -0700

    Prep for v1.1.3 of npm packages (microsoft#890)

commit 7b63fd3
Author: Mu Guo <guom08@gmail.com>
Date:   Thu Sep 27 12:16:14 2018 +0800

    Support cases like "Monday at 2.30", "Let's meet before 2.30pm" in Javascript (microsoft#889)

commit d6669a3
Author: Börje Karlsson <tellarin@gmail.com>
Date:   Wed Sep 26 20:37:04 2018 -0700

    - Updating Numbers and Units nuget package descriptions; (microsoft#888)

    - Removing incorrectly registered Japanese model that are not yet ready.

commit a7d7041
Author: Mu Guo <guom08@gmail.com>
Date:   Wed Sep 26 17:50:03 2018 +0800

    Support cases like "Monday at 2.30", "Let's meet before 2.30pm" (microsoft#884)

    * Support cases like "Monday at 2.30", "Before 2.30am"

commit 71c4433
Author: Nanhan Huang <38458025+Sothan@users.noreply.github.com>
Date:   Wed Sep 26 11:33:51 2018 +0800

    [EN DateTimeV2] Fix the behavior of 'later than' in JavaScript to make it the same as in .NET (microsoft#887)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tellarin tellarin tellarin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joseques @tellarin