-
Notifications
You must be signed in to change notification settings - Fork 57
[Dev] Implement ScheduleUnsafeInjectCallArgument Primitive to Hack decoding #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ability and maintainability
Contributor
Author
|
Also fixed codeql warning ref to #121 |
Contributor
Author
|
Add GPTQ Repack Test to checkout the integration correctness. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of decoding and memory prefetching in the GPU intrinsics and matmul dequantization logic. The key changes involve adding support for offset handling in decoding functions, updating the pass context for TVM transformations, and enhancing the scheduling logic for shared memory prefetching.
Decoding Enhancements:
decode_i4_to_f16_scale_offset,decode_i4s_to_f16_scale_offset, anddecode_i4u_to_f16_scale_offsetto handle offset during decoding (bitblas/gpu/intrin/lop3.py).get_fast_decode_intrinto append_offsetto function names whenstorage_scopeis "warp" and scaling is enabled (bitblas/gpu/intrin/lop3.py).TVM Transformation Context:
tvm_callback_cuda_postprocfunction to include"tir.disable_cse_tir": Truein the TVM pass context configuration (bitblas/base/utils.py).Scheduling and Prefetching:
sch_shared_memory_prefetch_with_config(bitblas/gpu/matmul_mma_dequantize.py).get_param_indicesandfetch_to_sharedfunctions to support reduction across threads (bitblas/gpu/matmul_mma_dequantize.py). [1] [2]Intrinsic Definitions:
intrin_definitionsto support various configurations (bitblas/gpu/intrin/lop3.py).These changes collectively enhance the functionality and performance of the GPU intrinsics and matmul dequantization processes.