Added aria-label to all button elements #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndyer
added a commit
that referenced
this pull request
Apr 9, 2013
Added aria-label to all button elements
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this pull request
Oct 18, 2013
Added aria-label to all button elements
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Added aria-label to all button elements
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Added aria-label to all button elements
marmite22
pushed a commit
to HT2-Labs/elucidat-mediaelement
that referenced
this pull request
Dec 16, 2016
Added aria-label to all button elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After getting feedback from a screenreader user I added aria-labels to all buttons. This improves readability for all blind users as screenreaders capable of using aria attributes can use it to tell the users better what that button is doing.