Synchronize code with description #42943
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The descriptive text says that the min attribute is omitted, but it was included. The min attribute can in fact be omitted, and having an example showing this is beneficial.
Contributor
|
Preview URLs (1 page) |
chrisdavidmills
approved these changes
Jan 28, 2026
Contributor
chrisdavidmills
left a comment
There was a problem hiding this comment.
LGTM; thanks, @Rosuav.
I agree that removing the attribute is the best option.
Contributor
Author
|
Thank you! Fast turnaround, appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple change to one of the examples for the Meter element
Motivation
The descriptive text says that the min attribute is omitted, but it was included. The min attribute can in fact be omitted, and having an example showing this is beneficial.
Additional details
The alternative fix would be to remove the paragraph above the example stating that the min attribute is omitted. Either would be acceptable, but keeping the note and the distinction showcases another aspect of the meter's functionality.
Related issues and pull requests