Skip to content

Conversation

@themartorana
Copy link
Contributor

If user.Current() isn't available (FreeBSD/Darwin when cross-compiled, see: golang/go#6376) attempts to use os.Getenv("HOME") before panic.

@coveralls
Copy link

coveralls commented Mar 1, 2018

Coverage Status

Coverage decreased (-0.3%) to 56.33% when pulling 9ad5be4 on Flyclops:fix-current-user-freebsd into eaf2844 on maruel:master.

@maruel
Copy link
Owner

maruel commented Mar 1, 2018

Fair enough. I'm not fan of the panic() call but that's code that I plan to refactor anyway, so make sure I'll keep the fallback logic when it gets refactored. Thanks!

@maruel maruel merged commit af628dd into maruel:master Mar 1, 2018
@themartorana
Copy link
Contributor Author

Right on - I left panic in there because I didn't dedicate the time to understand what effect that would have. But I'm always happy to see a panic go away. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants