Fix onSettled call when provided in hook time options#11139
Merged
Conversation
djhi
reviewed
Jan 27, 2026
| create: jest.fn(() => Promise.resolve({ data: { id: 1 } } as any)), | ||
| }); | ||
| let localCreate; | ||
| let settled = false; |
Contributor
There was a problem hiding this comment.
Wouldn't the test code be simpler if you passed a jest.fn to the onSettled option and checked it was called?
djhi
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #11137
onSettledisn't called anymore when provided in options ofuseCreate,useDeleteanduseDeleteMany.Solution
This is because we define a custom
onSettledfunction when callinguseMutationWithMutationMode. The solution is to callonSettledwhen provided in the options.How To Test
Here is an example of component that should call onSettled when clicking on the button:
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature