[TypeScript] Fix ref type regression when wrapping react-admin Button components#11135
Merged
[TypeScript] Fix ref type regression when wrapping react-admin Button components#11135
ref type regression when wrapping react-admin Button components#11135Conversation
Madeorsk
approved these changes
Jan 26, 2026
ref type regression when wrapping react-admin Button components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11134
How to Test
Create a small wrapper around EditButtonProps (like the one from issue #11134):
EditButton renders a MUI Button with component={LinkBase} + forwardRef, so its props should be typed as ButtonProps
<typeof LinkBase>(not the default button props). This aligns EditButton, CloneButton, and ListButton with the existing pattern used by ShowButton.Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature