[Storybook] Fix <ArrayInputBase> story issue when adding back a removed item#11041
Merged
fzaninotto merged 1 commit intomasterfrom Nov 13, 2025
Merged
[Storybook] Fix <ArrayInputBase> story issue when adding back a removed item#11041fzaninotto merged 1 commit intomasterfrom
<ArrayInputBase> story issue when adding back a removed item#11041fzaninotto merged 1 commit intomasterfrom
Conversation
fzaninotto
approved these changes
Nov 13, 2025
slax57
reviewed
Nov 14, 2025
|
|
||
| return fields ? ( | ||
| <SimpleFormIteratorBase {...props}> | ||
| <SimpleFormIteratorBase getItemDefaults={getItemDefaults} {...props}> |
Contributor
There was a problem hiding this comment.
This would probably deserve an update to the https://marmelab.com/ra-core/simpleformiteratorbase/ docs
<ArrayInputBase> story issue when adding back a removed item<ArrayInputBase> story issue when adding back a removed item
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When you remove an item from the
<ArrayInputBase>and add another, the values from the previously added item are used.Solution
This is because RHF requires that you provide values for a new item. As we can't know what inputs users will add, we have to actually inspect the
SimpleFormIteratorchildren to get their default values and use them for the new item. Until we have a better option, we extracted a hook to help with that.How To Test
=> you should have a new empty item
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature