[chore] Fix release script copies invalid node_modules subfolder#11038
Merged
[chore] Fix release script copies invalid node_modules subfolder#11038
Conversation
djhi
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release script copies everything inside the package folders into EE node_modules. This causes an issue because it also copies a folder under
node_modules/react-admin/node_modules/ra-ui-materialui, which causes a weird TS error when buildingra-rbacabout components not being portable.Solution
Also exclude this folder from the copy (it should not be there when installing the package from npm anyway)
How To Test
Run step 3 of the release script, then attempt to build ra-rbac
make build-ra-rbac.Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.