Fix optimistic query invalidation and avoid invalidating the same query twice#11017
Merged
Fix optimistic query invalidation and avoid invalidating the same query twice#11017
Conversation
…tion Fix optimistic query invalidation
djhi
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#11013 introduced a fix for optimistic query invalidation, but it was reverted in #11016 because it resulted in duplicate dataProvider calls in some scenarios.
Solution
The initial implementation of #11013 introduced invalidating queries using the provided query keys list, but also kept invalidating queries from the snapshot. This could result in calling
queryClient.invalidateQueries()twice on overlapping query keys.For instance:
[ "posts", "getList" ]and
[ "posts", "getList", { "pagination": { "page": 1, "perPage": 10 }, "sort": { "field": "published_at", "order": "DESC" }, "filter": {} } ]This is what caused the duplicate call to
getList.The solution is to only keep the provided query keys list, because the snapshot is created from this provided list, so the query keys from the snapshot are a subset of the provided query keys set.
How To Test
getListcallAdditional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.