[Chore] Use ReactNode instead of ReactElement where applicable#10998
Closed
jonathanarnault wants to merge 1 commit intochore/core-react-nodefrom
Closed
[Chore] Use ReactNode instead of ReactElement where applicable#10998jonathanarnault wants to merge 1 commit intochore/core-react-nodefrom
jonathanarnault wants to merge 1 commit intochore/core-react-nodefrom
Conversation
djhi
suggested changes
Oct 22, 2025
Contributor
djhi
left a comment
There was a problem hiding this comment.
I think you missed the <Datagrid expand> prop as it takes a ReactNode too according to both the doc and JSDoc (https://github.com/marmelab/react-admin/pull/10998/files#diff-1458ac898ea2924cc9ba84a442d85a75980a77a4f53823799136600375603063R401)
66a5156 to
7b12a15
Compare
b718465 to
4da0ee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #10996
Problem
A lot of RA components expect a
ReactElementwhere aReactNodecould be used.Solution
Replace
ReactElementwithReactNodewhere applicable.How To Test
N/A
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.