Update index.d.ts #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hey @stefanprobst, does this work for your use case? |
src/index.d.ts
Outdated
| @@ -1,5 +1,7 @@ | |||
| import {NextConfig} from 'next'; | |||
There was a problem hiding this comment.
Suggested change
| import {NextConfig} from 'next'; | |
| import type {NextConfig} from 'next'; |
src/index.d.ts
Outdated
| options?: MarkdocNextJsOptions | ||
| ): (config: NextConfig) => NextConfig; | ||
|
|
||
| export = createMarkdocPlugin; |
There was a problem hiding this comment.
hmm ts says: "TS2309: An export assignment cannot be used in a module with other exported elements."
Contributor
Author
There was a problem hiding this comment.
I'll try export default instead
Contributor
Author
|
Thanks for the review @stefanprobst! I really appreciate it. Made the updates you suggested—lmk what you think. |
stefanprobst
approved these changes
Oct 13, 2023
stefanprobst
left a comment
There was a problem hiding this comment.
LGTM 👍
checked in a vanilla create-next-app and in my own project.
|
@mfix-stripe when do you plan to release this? |
Contributor
Author
|
Thanks for the nudge @stefanprobst — releasing right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes markdoc/markdoc#454