Skip to content

Segregate optionally based on bucket, fix tests #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vitaminmoo merged 1 commit into from
Mar 18, 2022
Merged

Segregate optionally based on bucket, fix tests #99

vitaminmoo merged 1 commit into from
Mar 18, 2022

Conversation

@vitaminmoo
Copy link
Member

@vitaminmoo vitaminmoo commented Mar 17, 2022

  • If we have a bucket, use it in the path so we don't stomp other
    buckets' files
  • Also make localfs tests parallel compatible
  • Use require more

@vitaminmoo
Segregate optionally based on bucket, fix tests
827594f 
- If we have a bucket, use it in the path so we don't stomp other
  buckets' files
- Also make localfs tests parallel compatible
- Use require more
@vitaminmoo vitaminmoo self-assigned this Mar 17, 2022
@vitaminmoo vitaminmoo marked this pull request as ready for review March 17, 2022 17:08
@vitaminmoo vitaminmoo merged commit b80c772 into master Mar 18, 2022
@vitaminmoo vitaminmoo deleted the localfs-tests-and-bucket-prefixes branch March 18, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajroetker ajroetker ajroetker approved these changes

Assignees

@vitaminmoo vitaminmoo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vitaminmoo @ajroetker