Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Selenium.pm #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

James-Switzer
Copy link

Fixed bug in get_string_array where instead of correctly returning an empty array when there are no results it returns an array containing a single empty string. The new code uses a negative lookbehind assertion to split on unescaped commas. It then uses a map to remove the escape characters from the list of strings.

Fixed bug in get_string_array where instead of correctly returning an empty array when there are no results it returns an array containing a single empty string. The new code uses a negative lookbehind assertion to split on unescaped commas. It then uses a map to remove the escape characters from the list of strings.
@lukec
Copy link
Owner

lukec commented Oct 15, 2013

Are you able to become a co-maintainer? I don't have time for this module lately.

@James-Switzer
Copy link
Author

What kind of help are you looking for and what kind of time commitments
would it involve? I don't have tons of free time myself, but I might be
able to get a little time at work to help out. I've pitched my boss on
doing it for the street cred / OSS karma and he sounds interested, but more
details make for an easier sell.

jamess

On Mon, Oct 14, 2013 at 8:39 PM, Luke Closs [email protected]:

Are you able to become a co-maintainer? I don't have time for this module
lately.


Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-26307243
.

@lukec
Copy link
Owner

lukec commented Oct 19, 2013

Hi,

I would just like someone to take over being the maintainer. I don't
follow selenium much anymore, so I'm out of date when it comes to fixing
things.

It's not very much work, mostly accepting the odd patch or making a
release. I can help advise if you'd like.

Best,
Luke

On Wed, Oct 16, 2013 at 2:54 PM, James Switzer [email protected]:

What kind of help are you looking for and what kind of time commitments
would it involve? I don't have tons of free time myself, but I might be
able to get a little time at work to help out. I've pitched my boss on
doing it for the street cred / OSS karma and he sounds interested, but
more
details make for an easier sell.

jamess

On Mon, Oct 14, 2013 at 8:39 PM, Luke Closs [email protected]:

Are you able to become a co-maintainer? I don't have time for this
module
lately.


Reply to this email directly or view it on GitHub<
https://github.com/lukec/cpan-selenium-rc-perl/pull/7#issuecomment-26307243>

.


Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-26462177
.

@joemcmahon
Copy link
Collaborator

I can take it, Luke.

On Saturday, October 19, 2013, Luke Closs wrote:

Hi,

I would just like someone to take over being the maintainer. I don't
follow selenium much anymore, so I'm out of date when it comes to fixing
things.

It's not very much work, mostly accepting the odd patch or making a
release. I can help advise if you'd like.

Best,
Luke

On Wed, Oct 16, 2013 at 2:54 PM, James Switzer <[email protected]<javascript:_e({}, 'cvml', '[email protected]');>>wrote:

What kind of help are you looking for and what kind of time commitments
would it involve? I don't have tons of free time myself, but I might be
able to get a little time at work to help out. I've pitched my boss on
doing it for the street cred / OSS karma and he sounds interested, but
more
details make for an easier sell.

jamess

On Mon, Oct 14, 2013 at 8:39 PM, Luke Closs <[email protected]<javascript:_e({}, 'cvml', '[email protected]');>>wrote:

Are you able to become a co-maintainer? I don't have time for this
module
lately.


Reply to this email directly or view it on GitHub<

https://github.com/lukec/cpan-selenium-rc-perl/pull/7#issuecomment-26307243>

.


Reply to this email directly or view it on GitHub<
https://github.com/lukec/cpan-selenium-rc-perl/pull/7#issuecomment-26462177>

.


Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-26652422
.

@mattp-
Copy link
Collaborator

mattp- commented Oct 21, 2013

hi all,
I can handle the merge and release, as luke already threw me commitbit.maintainership many months back. Before merge I would prefer some level of unit testing on your change if possible?

Thanks,
Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants