Skip to content

GC-2518/fixes letters tracking event validation #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanfriss merged 3 commits into from
Mar 11, 2024
Merged

GC-2518/fixes letters tracking event validation #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83e92ca
fixes validation
juanfriss Mar 11, 2024
fa7f60b
adds validation for letter file
juanfriss Mar 11, 2024
bb027f8
fixes validation
juanfriss Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lob_python/model/letter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,15 @@ class Letter(ModelNormal):
}

validations = {
('tracking_events',): {
'max_items': 0,
('template_id',): {
Copy link
Contributor Author

@juanfriss juanfriss Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same sort of validation postcards or self mailers have

'regex': {
'pattern': r'^tmpl_[a-zA-Z0-9]+$', # noqa: E501
},
},
('template_version_id',): {
'regex': {
'pattern': r'^vrsn_[a-zA-Z0-9]+$', # noqa: E501
},
},
}

Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from setuptools import setup, find_packages # noqa: H301

NAME = "lob-python"
VERSION = "5.1.2"
VERSION = "5.1.3"
# To install the library, run the following
#
# python setup.py install
Expand Down