Filter invalid bounding boxes in instance segmentation#610
Merged
Conversation
Contributor
Author
|
/review |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds filtering of invalid bounding boxes in instance segmentation transforms, applying the same filtering pattern already used in object detection models. This ensures that bounding boxes that become invalid after transformations (e.g., due to cropping or rotation) are properly filtered out.
Changes:
- Added conditional bbox filtering parameters (
filter_invalid_bboxesandclip) to instance segmentation train transforms, matching the pattern used in object detection - Updated CHANGELOG.md to document the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lightly_train/_task_models/dinov3_eomt_instance_segmentation/transforms.py | Added version-conditional bbox filtering parameters (filter_invalid_bboxes for albumentations>=2.0.1 and clip for albumentations>=1.4.5) to DINOv3EoMTInstanceSegmentationTrainTransformArgs |
| CHANGELOG.md | Added entry documenting the fix for invalid bounding box filtering in instance segmentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What has changed and why?
How has it been tested?
Did you update CHANGELOG.md?
Did you update the documentation?