-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc/sa: Implement deep health checks #6928
Conversation
0074147
to
5f34810
Compare
5f34810
to
d8cb2ff
Compare
I thought I understood this, but I don't yet.
@pgporada and I had a call to chat through his questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly tiny code organization comments. Last top-level comment: it would be great to have a unittest that tests the check
closure: sets up a health server, supplies a tiny fake health check function, and ensures that the health server's status was updated appropriately. This may require busting check
all the way out to being a method on serverBuilder
or something like that, rather than being a closure =/
Add the necessary scaffolding for deep health checking of our various gRPC components. Each component implementation that also implements the grpc.checker interface will be checked periodically, and the health status of the component will be updated accordingly.
Add the necessary methods to SA to implement the grpc.checker interface and register these new health checks with Consul.
Additionally:
Fixes #6878
Part of #6795