Skip to content

Add focus trapping to resource preview side panel#5505

Merged
akolson merged 6 commits intolearningequality:hotfixesfrom
AllanOXDi:focus-on-me
Oct 30, 2025
Merged

Add focus trapping to resource preview side panel#5505
akolson merged 6 commits intolearningequality:hotfixesfrom
AllanOXDi:focus-on-me

Conversation

@AllanOXDi
Copy link
Member

@AllanOXDi AllanOXDi commented Oct 23, 2025

Summary

This PR fixes focus trapping to resource preview side panel

Before

focus-resource-preview-sidebar.mp4

After

Screen.Recording.2025-10-23.at.21.54.00.mov

References

#5406

Reviewer guidance

  • Sign in to Hotfixes with an account with enabled search recommendations
  • Go to a channel and try to import resources from other channels
  • Open the side panel for a selected resource

@pcenov
Copy link
Member

pcenov commented Oct 27, 2025

Hi @AllanOXDi and @AlexVelezLl, noticed that this PR is with status 'Needs QA' but we can only test it either at unstable or hotfixes so I'm changing the status to "In review" instead.

@akolson
Copy link
Member

akolson commented Oct 27, 2025

Hi @pcenov! This should be testable once merged to the hotfixes. We'll let you know once its ready for QA review. Thanks

akolson
akolson reviewed Oct 28, 2025
View reviewed changes
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Allan! Manual QA and code LGTM! Just a few suggestions on clean up and we should be good. Thanks!

@AllanOXDi AllanOXDi requested a review from akolson October 28, 2025 15:09
@AllanOXDi AllanOXDi requested a review from akolson October 28, 2025 16:01
akolson
akolson approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @AllanOXDi

akolson
akolson requested changes Oct 28, 2025
View reviewed changes
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the build is failing, will add a blocker to avoid an accidental merge. Has nothing to do with the code. Seems like some python dependency is failing for some reason!

@akolson
Copy link
Member

akolson commented Oct 28, 2025

@rtibbles any idea why this build is failing?

@akolson
Copy link
Member

akolson commented Oct 30, 2025

Hey @AllanOXDi! could you please rebase this pr? Thanks

@AllanOXDi
Copy link
Member Author

AllanOXDi commented Oct 30, 2025

Done!

akolson
akolson approved these changes Oct 30, 2025
View reviewed changes
Copy link
Member

@akolson akolson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging into hotfixes next patch release. Thanks @AllanOXDi

@akolson akolson merged commit c49d767 into learningequality:hotfixes Oct 30, 2025
13 checks passed
@akolson akolson mentioned this pull request Oct 30, 2025
Closed
@marcellamaki marcellamaki mentioned this pull request Nov 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akolson akolson akolson approved these changes

@AlexVelezLl AlexVelezLl Awaiting requested review from AlexVelezLl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AllanOXDi @pcenov @akolson