Adds defensive check when reading file_format on file object#5440
Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom Oct 9, 2025
Merged
Conversation
bjester
approved these changes
Oct 9, 2025
Member
bjester
left a comment
There was a problem hiding this comment.
This looks good assuming this error occurred because of the file checks in the template being computed despite being conditionally after !file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pr adds a defensive check against the error reported in sentry as detailed in #5412
References
Fixes #5412
Reviewer guidance