Reinstate .styl noop replacement for production webpack builds#5344
Merged
rtibbles merged 1 commit intolearningequality:hotfixesfrom Aug 28, 2025
Merged
Reinstate .styl noop replacement for production webpack builds#5344rtibbles merged 1 commit intolearningequality:hotfixesfrom
rtibbles merged 1 commit intolearningequality:hotfixesfrom
Conversation
rtibbles
approved these changes
Aug 28, 2025
Member
rtibbles
left a comment
There was a problem hiding this comment.
Manual testing checks out. I can't for the life of me remember how this works, but hopefully we'll just get rid of Vuetify and I'll never have to remember!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-adds module replacement in the webpack config for Vuetify's stylus files, but more specifically only targeting
.stylfiles. Without this specificity, other resolution failures occur formini-css-extract-plugin/dist/hmr/hotModuleReplacement.js, which was the original cause for removal during the pnpm transition.References
source #4106
closes #5342
Reviewer guidance
npx webpack serve --env prod --config webpack.config.js --progressandpnpm run runserver