Use KTransition instead of VSlideYTransition in 'Request more space' form#5194
Use KTransition instead of VSlideYTransition in 'Request more space' form#5194MisRob merged 3 commits intolearningequality:unstablefrom
Conversation
|
@yeshwanth235 Thank you for your contribution! ❤️ Please remember what we mentioned previously regarding the more descriptive PR titles, thank you! |
|
Hi @yeshwanth235, thanks! Code is as expected. For manual testing - after we merge #5210 (I expect that within next few days), would you rebase your pull request on top of the latest |
|
Sure @MisRob |
|
@yeshwanth235 #5210 is now merged |
|
Update the PR @MisRob |
There was a problem hiding this comment.
Thanks @yeshwanth235, I confirm it looks as expected.
If you'd like to keep contributing to this project, you're welcome to medium complexity issues if you'd like - from few issues you've resolved recently I've had an impression you have built a good grasp on how KDS in relationship to Studio works.
Thanks @MisRob. Sure, will start contributing to medium complexity issues |
|
Hi @MisRob |
|
Hi @yeshwanth235, I've just assigned last one. I have several in preparation though - they will all be posted in the next two days or so :) |
|
If you'd like @yeshwanth235, here's one that's available - I left a note that it's reserved for you, but first have a look if that's something you'd be interested in #5217 |
Summary
Updated VSlideYTransition to KTransition
References
Fixes #5081
Reviewer guidance
Manual testing
Check whether form is show on click of open form
Check whether form is getting closed on click of close form
Note: With the release of the new KDS version containing the KTransition fix, this PR is ready for merging