Remove unused code and dependencies#4934
Merged
bjester merged 3 commits intolearningequality:unstablefrom Mar 3, 2025
Merged
Conversation
Clean up resultant unused dependencies. Clean up outdated/unused pytest plugins.
Member
Author
|
D'oh! |
c38f14c to
2d62ff2
Compare
Remove use of builtins imports. Fix linting errors from commit.
2d62ff2 to
da424e8
Compare
bjester
approved these changes
Mar 3, 2025
Member
bjester
left a comment
There was a problem hiding this comment.
LGTM - hopefully no surprises
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
django-mathfiltersdependencyReferences
Inspired by numerous dependabot upgrade PRs for dependencies we do not need
Reviewer guidance
I think as long as tests pass this should be OK!